In Dark mode, add on Options UI text invisible in Dark mode (dark on dark)
Categories
(Toolkit :: Themes, defect)
Tracking
()
People
(Reporter: u639837, Unassigned)
Details
Attachments
(2 files)
demo.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36
Steps to reproduce:
Tested with Nightly, 69.0a1 (2019-05-28) (64-bit)
Reproduction steps:
- Load a very primitive extension included below
- Set your OS theme to "dark"
- Open the extension options UI
Note: Firefox injects its own style sheets since manifest key options_ui.browser_style key is missing, so it is presumed to be true as per docs[1]
[1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles
Extension:
Contents of mainfest.json:
{
"name": "Demo",
"version": "0.0",
"description": "Demo",
"author": "Demo",
"manifest_version": 2,
"options_ui": {
"page": "options_ui.html"
}
}
Contents of options_ui.html:
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Options</title>
</head>
<body>
<p style="background: white">You can see this</p>
<p>You can't see this</p>
</body>
</html>
Actual results:
In Dark Mode, the second line "You can't see this" is virtually indistinguishable from background (it is dark text on dark background). See the attached demo.png.
Expected results:
In Dark Mode, extensions text is light to contrast with the background. (The injected style should make text dark if Dark mode is enabled).
| Comment hidden (typo) |
|
||
Updated•7 years ago
|
|
|
||
Comment 3•7 years ago
|
||
(In reply to bershan2 from comment #2)
Related bug: 1544212
It's a duplicate of it, based on the screenshot attached there. Also, entering about:config into the address bar and setting extensions.htmlaboutaddons.enabled to true seems to fix it.
Also, entering about:config into the address bar and setting extensions.htmlaboutaddons.enabled to true seems to fix it.
For me this only hides the whole UI altogether (see demo2.png), but since it is the intended behavior I'll close this issue.
Description
•