Closed Bug 1556306 Opened 6 years ago Closed 6 years ago

Edit Attachment As Comment now uses variable rather than fixed width font

Categories

(bugzilla.mozilla.org :: User Interface, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: iannbugzilla, Assigned: kohei)

References

(Regression)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Details | Review

STR
1/ Create bug and add patch
2/ Select "Details" link on attached patch
3/ Select "Edit Attachment As Comment"
4/ Look at font used

Expected Result
1/ Font used is a fixed width one

Actual Result
1/ Font used is a variable width one

This makes reviewing patches, especially checking the format/indentation of patches, difficult.

Looks like it’s a regression from Bug 1552885. The posted comment is rendered in monospace as intended, but the <textarea> should also be displayed in monospace. PR coming.

Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
OS: Linux → All
Regressed by: 1552885
Hardware: x86_64 → All

I meant Bug 1377977.

Regressed by: bmo-jedi-theme
No longer regressed by: 1552885
Attached file GitHub Pull Request

Merged to master.

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: