1552885 - Fix issues in the post-Sandstone skin including low contrast, visited links and small font size

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Julien Wajsberg [:julienw]]

Hey,

thanks for the new interface, it looks great !

I found some contrast problems that could be a problem for accessibility, let me try to summarize these. I'm not an expert in this field but I have worked on the subject in the past.

• the scrollbar is really not contrasted enough with 1/ the page and 2/ the scrollbar background. This is bad even for me, whereas I have no particular vision issue.
• the quoted text is too pale compared to its background.
• the "reporter" text next to the reporter's name in comments is not contrasted enough.

Thanks!

Comment 2

[Paul Adenot (:padenot)]

Attachment: how to check for contrast on a page

We have a tool to check for this all at once.

Alternatively, the element picker allow checking the score for a particular element.

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Like I wrote in bug #1552899, I will write it here too, so it won't be omitted and forgotten.

I'm using glasses and Bugzilla in 130-150% zoomed mode with disabled modal user interface (I prefer old one),
and for me this new text font looks kinda blurry and causes me eye strain.
Looks like without sub-pixel anti-aliasing, but only gray-scale anti-aliasing (but it's not).

Any chances to reconsidering this change, please?
And use black text font color, instead of grey shades,
or at least providing option to change this.

Thank you very much in advance!

BTW - New Bugzilla look looks nice and clean. I like it. Good job!

Comment 5

[Jorg K (CEST = GMT+2)]

I played around with the previous CSS from https://raw.githubusercontent.com/mozilla-bteam/bmo/96794c429d269d95498999e9d3d90b5c50c56b82/skins/standard/global.css.

The font was 'Fira Sans', now 'FiraGo'. The previous font had a different aspect ration, so the text was wider which no doubt made it look bigger. It was also darker. Looks like the new font is also not rendered very clearly on Windows.

Comment 6

[Kohei Yoshino]

FiraGO is a variant of Fira Sans, so there are no substantial differences between those two. What’s changed is the font weight: previously it was Regular and now Book, which should be readable on screen thanks to the consistent line width. By the way, did you test with the latest version of Firefox, not 60 ESR?

Comment 7

[Jorg K (CEST = GMT+2)]

Looks the same (small) in Nightly.

Comment 8

[Wayne Mery (:wsmwk)]

Same font badness in chrome (beta). And not any better on desktop monitor than laptop. (I concur with the issues mentioned in bug 1552899.)
I'd also prefer to see background shading of all comments be totally removed - less eye strain

Comment 11

[Kohei Yoshino]

Once more thing: checkboxes on the modal modules (this page) look collapsed.

Comment 12

[Jorg K (CEST = GMT+2)]

I've just noticed an absolutely FATAL issue: Visited links are not shown in a different colour any more. That makes bug triaging pretty much impossible. For bug triaging I get a list of recent bugs, like https://mzl.la/2Q74Pr8, and then visit the bugs I haven't looked at. I cannot possibly remember all the bugs I have already looked at, Firefox needs to tell me. So if visited links are not shown in a different colour, I'm hosed :-(

Comment 13

[Kohei Yoshino]

That’s an intentional change. See Bug 1531517 and Bug 1552922 for why.

Comment 14

[Jorg K (CEST = GMT+2)]

Well, reading those bugs, I can see that some BMO professionals aren't very happy with that, see "The visited link contrast is very useful for me when I'm triaging through a long list of bugs".

Another issue: The requests box, the popup you get clicking onto the red circle with the number of requests, is too small, you can't see the requests any more.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Jorg, this bug is about contrast, please don't fork it.
If you care about the link, please comment in the bug.
If you care about the requests box, please create a new bug.

Comment 16

[Kohei Yoshino]

(In reply to Jorg K (GMT+2) from comment #14)

Another issue: The requests box, the popup you get clicking onto the red circle with the number of requests, is too small, you can't see the requests any more.

This bug can cover any regression but I haven't changed the font size nor font weight...

Comment 17

[Jorg K (CEST = GMT+2)]

See bug 1552922 comment #10 and above to set CSS for this site to change font size and colour.

Comment 18

[:aceman]

For the record, the new CSS is completely ignored in Internet Explorer 11 (the latest version on still supported Windows 7), thus it has high contrast (black text on white background), but there are no backgrounds and borders, thus no separations of comments.
Also no buttons seem to work, thus BMO is completely inoperable in the browser.

Comment 19

[Kohei Yoshino]

We don’t support Internet Explorer. See this wiki page for requirements.

Comment 21

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please note that the bug suggestion table also looks like cut-off on both the left and right side.

Comment 23

[Dylan Hardison [:dylan] (he/him)]

(In reply to Jorg K (GMT+2) from comment #12)

I've just noticed an absolutely FATAL issue: Visited links are not shown in a different colour any more. That makes bug triaging pretty much impossible. For bug triaging I get a list of recent bugs, like https://mzl.la/2Q74Pr8, and then visit the bugs I haven't looked at. I cannot possibly remember all the bugs I have already looked at, Firefox needs to tell me. So if visited links are not shown in a different colour, I'm hosed :-(

In particular, bug 1531517 comment #3 goes into details

1. It’s basically broken since CSS was invented. For example, the following links are all the same page but considered as different links.
   [snip]
2. The style will be easily reset once the browser’s history is cleared.
3. The style could be inconsistent among multiple browsers and devices unless the user’s browsing history is completely synced.

[snip] we need a server-side solution to reliably mark visited/read bugs like an email client or feed reader.
Bugzilla is already logging the user’s last visited timestamp on bugs, so we could use the data. [snip]

So we will have visited bugs highlighted differently, but it will be server-side.

Comment 28

[Kohei Yoshino]

Attachment: GitHub Pull Request

Comment 31

[Kohei Yoshino]

PR merged to master. Should be deployed early next week. Thank you all for your feedback! I’ll continue polishing the new skin over the course of time.