Closed Bug 1556784 Opened 6 months ago Closed 6 months ago

68 train: Rename `{promote,ship}_fennec` into `{promote,ship}_fennec_beta`

Categories

(Release Engineering :: Release Automation: Other, task)

task
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
Tracking Status
firefox68 --- fixed

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(3 files, 1 obsolete file)

We will need to spin {promote,ship}_fennec_release off mozilla-esr68. Therefore, let's rename the existing target tasks now and introduce the new ones later.

Could you update the braindump params files to match?

Thanks for spotting that, Aki. I ended up creating new param files, instead of changing the existing ones. The reason is: this current patch is intended to land on mozilla-beta only. So I kept the params as is, until we decide to kill Fennec on mozilla-central for good. (We haven't retired it from there, just in case we want to revert the whole "Fennec ESR" plan at the last minute)

Attachment #9069925 - Flags: review?(rail)
Comment on attachment 9069925 [details] [diff] [review]
[build/braindump] taskgraph-diff: Create params files for the 68 train (Fennec sunset)

Review of attachment 9069925 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should just update the existing files (renaming some of them as appropriate). We always have version control history if we decide to abandon fennec riding to esr68.

I'm worried that some files will always break if I run them against mozilla-central, or some other against mozilla-beta. Is there a way to filter out which files (under the same folder) are 68-compatible and some should be run against 69 or 67?

Flags: needinfo?(mozilla)

(In reply to Johan Lorenzo [:jlorenzo] from comment #4)

Created attachment 9069925 [details] [diff] [review]
[build/braindump] taskgraph-diff: Create params files for the 68 train (Fennec sunset)

Thanks for spotting that, Aki. I ended up creating new param files, instead of changing the existing ones. The reason is: this current patch is intended to land on mozilla-beta only. So I kept the params as is, until we decide to kill Fennec on mozilla-central for good. (We haven't retired it from there, just in case we want to revert the whole "Fennec ESR" plan at the last minute)

Aha. Then, if the params files are useful for you or for the rest of the team, we can put them in a separate params dir, possibly params-fennec/ or params-fennec-68. (If not useful, let's not :) I'd like to allow for testing against 68 code if it's useful, while still allowing someone running on central to run the full set of parameters in params/.

I agree we don't need the desktop params, just the Fennec ones. I put just the fennec-related files under params-fennec-68, like you suggested. Thanks!

Attachment #9069925 - Attachment is obsolete: true
Attachment #9069925 - Flags: review?(rail)
Attachment #9070198 - Flags: review?(rail)
Comment on attachment 9069696 [details] [review]
[release-services/shipit] 68 train: Rename `{promote,ship}_fennec` into `{promote…,ship}_fennec_beta`

landed
Attachment #9069696 - Flags: review?(rail) → review+
Comment on attachment 9070198 [details] [diff] [review]
[build/braindump] taskgraph-diff: Create params files for Fennec 68 (sunset)

Review of attachment 9070198 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #9070198 - Flags: review?(rail) → review+
Comment on attachment 9070198 [details] [diff] [review]
[build/braindump] taskgraph-diff: Create params files for Fennec 68 (sunset)

Landed on default at https://hg.mozilla.org/build/braindump/rev/35e30e3bfbda7f1fa6be308951ea128d5e71d503

Please let me know, Tom, if you'd prefer another way. I'm open to alternatives solutions. I landed this patch, just to be in sync with the content of mozilla-beta.

All patches landed/deployed. Closing this bug as fixed.

Please reply in this bug, if you'd like an alternative approach on the braindump patch, I'll be happy to reply back/address it.

Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Flags: needinfo?(mozilla)
Blocks: 1558507
Type: defect → task
You need to log in before you can comment on or make changes to this bug.