1548864 - Build and ship Fennec Nightly off mozilla-beta

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, task)

Description

[Johan Lorenzo [:jlorenzo]]

As part of the Fennec ESR68 transition plan[1], we need to let Fennec Nightly ride the 68 train. This means we want to ship Fennec nightly off mozilla-beta for a full cycle.
Most of this work will be useful when we migrate Fennec Nightly to mozilla-esr68. For instance, we want:

• the ability to create APKs with different branding off the same repo
• to schedule a nightly graph outside of mozilla-central
• to ensure geckoview remains shipped of the regular repos

What needs to be done

• Modify taskgraph to spawn both “nightly - the one we’ve had on mozilla-beta” and “nightly - the one that comes from central” jobs. Nightly jobs must remain in the nightly graph and Beta jobs on the promote one.
• Make sure we don't add/remove tasks on/from these graphs.
• Modify .cron.yml to schedule fennec_nightly on mozilla-beta https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/.cron.yml#83
• Ensure https://tools.taskcluster.net/auth/roles/project%3Areleng%3Anightly%3Alevel-3%3A* is used on mozilla-beta. It seems to already be the case https://tools.taskcluster.net/auth/roles/repo%3Ahg.mozilla.org%2Freleases%2Fmozilla-beta%3Acron%3Anightly-* . This allows the nightly graph to have the right scopes to ship to the org.mozilla.fennec_aurora Google Play product
• Modify declarative artifacts to not define a manifest based on by-project

Optional needs

We may want to keep the version numbers. This is tracked under bug 1548655

[1] https://docs.google.com/document/d/1oRPkwP3l7QzdQYj0Wn7d_3EfTZaakocA_i_pGKlG0dI/edit

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - Build and ship Fennec Nightly off mozilla-beta

Bug 1548864 - part 1: Factorize android.yml

Bug 1548864 - part 2: Enable -beta Android builds

Bug 1548864 - part 3: Change promote_fennec to handle beta tasks only

This means -nightly tasks don't end up in that promote graph.
The push-apk loader also wires the expected dependencies.

Bug 1548864 - part 4: Do not run any Android -beta balrog jobs

Bug 1548864 - part 5: Ensure geckoview Nightly is not shipped off mozilla-beta

Neither from the beta graph nor from the nightly one.
It's notably done by not exposing the geckoview artifacts on the nightly build tasks

Bug 1548864 - part 6: Run missing Nightly tasks on try

Bug 1548864 - part 7: Make single locale run on try too

Bug 1548864 - part 8: Bump mozapkpublisher so push-apk-checks expects ARM64 on beta

Bug 1548864 - part 9: .cron.yml: Let mozilla-beta schedule the Fennec nightly graph

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 1: Factorize android.yml r=tomprince

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 3: Enable `-beta` Android builds r=tomprince

Depends on D29849

Comment 4

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 4: Change promote_fennec to handle beta tasks only r=tomprince

This means -nightly tasks don't end up in that promote graph.
The push-apk loader also wires the expected dependencies.

Depends on D29850

Comment 5

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 4: Do not run any Android `-beta` balrog jobs r=tomprince

Depends on D29851

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 5: Ensure geckoview Nightly is not shipped off mozilla-beta r=tomprince

Neither from the beta graph nor from the nightly one.
It's notably done by not exposing the geckoview artifacts on the nightly build tasks

Depends on D29852

Comment 7

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 6: Run missing Nightly tasks on try r=tomprince

Depends on D29853

Comment 8

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 5: Make single locale run on try too r=tomprince

Depends on D29854

Comment 9

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 6: Bump mozapkpublisher so push-apk-checks expects ARM64 on beta r=tomprince

Depends on D29855

Comment 10

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 7: .cron.yml: Let mozilla-beta schedule the Fennec nightly graph r=tomprince

Depends on D29856

Comment 11

[Ryan VanderMeulen [:RyanVM]]

With QA doing their initial testing of the Try builds off those patch stack, we noticed that crash reports from Nightly builds are showing in Socorro as Beta release channel. Tracing that back, it looks like it's because MOZ_UPDATE_CHANNEL is being set to beta for those builds instead of nightly.

Comment 12

[Johan Lorenzo [:jlorenzo]]

That makes sense. I'm looking into it. Thanks for the report!

Comment 13

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 8: Run emulator tests on beta r=jmaher

Depends on D29857

Comment 14

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 9: Ensure MOZ_UPDATE_CHANNEL is set to either nightly or beta r=tomprince,jmaher

Depends on D31273

Comment 15

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 12: Ship Nightly to the alpha track of Google Play r=tomprince

Depends on D31274

Comment 16

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 2: Let should_use_artifact_map() not depend on the project anymore r=sfraser

Depends on D29849

Comment 17

[Phabricator Automation]

Comment on attachment 9065460 [details]
Bug 1548864 - part 2: Let should_use_artifact_map() not depend on the project anymore r=sfraser

Revision D31492 was moved to bug 1551738. Setting attachment 9065460 [details] to obsolete.

Comment 18

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 11: Let Fennec Nightly be signed by the nightly key r=tomprince

Comment 19

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 12: Fix beetmover version numbers on Fennec nightly r=tomprince

Depends on D31802

Comment 20

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1548864 - part 10: Use release-type attributes r=Callek

Depends on D31274

Comment 21

[Johan Lorenzo [:jlorenzo]]

Patch queue landed on mozilla-beta: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=1f2cf02d4beba08f432cb2a6fabb3d20a6a59ba9

We don't plan to land these changes on mozilla-central because:

• Fennec rides the 68 train (which is now on mozilla-beta)
• It enables Fennec Nightly to be resurrected on mozilla-central if we abort the Fennec ESR plan.

I found some minor issues after landing. I'm taking care of them in separate bugs. Thanks all, for the help!

Comment 22

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/65f7c0babe09
https://hg.mozilla.org/releases/mozilla-beta/rev/bf2b338d006a
https://hg.mozilla.org/releases/mozilla-beta/rev/f58c24f5f854
https://hg.mozilla.org/releases/mozilla-beta/rev/d51fe28644b8
https://hg.mozilla.org/releases/mozilla-beta/rev/851a7d71d980
https://hg.mozilla.org/releases/mozilla-beta/rev/52054d2cc61c
https://hg.mozilla.org/releases/mozilla-beta/rev/aae928d56c33
https://hg.mozilla.org/releases/mozilla-beta/rev/ec804fef742e
https://hg.mozilla.org/releases/mozilla-beta/rev/9196b576f69a
https://hg.mozilla.org/releases/mozilla-beta/rev/c6efa45fbc69
https://hg.mozilla.org/releases/mozilla-beta/rev/d3935fc2c8ec

Comment 24

[Rob Lemley [:rjl]]

Attachment: version_directory_TB.patch

Comment 25

[Nick Alexander :nalexander [he/him]]

johan: in the discussion and review of Bug 1522581, you suggested you were going to land part 1 of this series -- cleaning up android.yml -- to m-c. (Specifically, https://hg.mozilla.org/releases/mozilla-beta/rev/65f7c0babe09.) That didn't happen. Can we do that?

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e58101918c0
part 1: Factorize android.yml r=tomprince

Comment 27

[Johan Lorenzo [:jlorenzo]]

Thanks for your interest in this patch and for the reminder, Nick :) I didn't land it last week because I was bug 1522581 was close to land, and it seemed more important to land first. That said, I should have communicated it to you.

Anyway, I just rebased the patch on top of the latest central (which includes bug 1522581) and pushed it. Thanks again for the reminder.

Comment 28

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1e58101918c0