1557074 - Re-Enable Mozilla Content Process Isolation

Status: VERIFIED FIXED

(Core :: DOM: Content Processes, defect, P2)

Description

[Tom Ritter [:tjr]]

This bug's blockers are the things we need to fix to re-enable this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Ryan Kelly [:rfkelly]]

Noting for context, re-enablement will be done by switching the browser.tabs.remote.separatePrivilegedMozillaWebContentProcess pref from false to true, and once can do this locally for testing purposes.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Relman may want to keep an eye on this for Nightly 71.

Comment 4

[Ioana Rusiczki]

(In reply to Ryan Kelly [:rfkelly] from comment #2)

Noting for context, re-enablement will be done by switching the browser.tabs.remote.separatePrivilegedMozillaWebContentProcess pref from false to true, and once can do this locally for testing purposes.

Does it mean that qa can do the AMO installs and Fxa testing on Nightly 71 by switching the mentioned pref on true or we must wait until we see it on true in about:config ( this is what I understand by being automatically enabled) ?

Also, should we wait until https://bugzilla.mozilla.org/show_bug.cgi?id=1556655 is fixed first ?

There is a PI filed for AMO installs and Fxa https://jira.mozilla.com/browse/PI-147 where Firefox Release Train is 70 and testing was requested only on beta (beta70). Manual qa was not requested for Nightly but only for Beta. I can update the PI with the correct testing environments if I get the correct information.

So please let us know.
Thanks!

Comment 5

[Tom Ritter [:tjr]]

(In reply to Ioana Rusiczki from comment #4)

(In reply to Ryan Kelly [:rfkelly] from comment #2)

Noting for context, re-enablement will be done by switching the browser.tabs.remote.separatePrivilegedMozillaWebContentProcess pref from false to true, and once can do this locally for testing purposes.

Does it mean that qa can do the AMO installs and Fxa testing on Nightly 71 by switching the mentioned pref on true or we must wait until we see it on true in about:config ( this is what I understand by being automatically enabled) ?

You can switch it now and test.

Also, should we wait until https://bugzilla.mozilla.org/show_bug.cgi?id=1556655 is fixed first ?

No, I will land a fix for this separately and verify it myself. The underlying problem causing this (relating to process switching during downloads) was concerning to me; but I could not cause it outside of this specific scenario (e.g. by doing Save Link As or anything else), so if it is a problem hopefully it will show up during your testing.

There is a PI filed for AMO installs and Fxa https://jira.mozilla.com/browse/PI-147 where Firefox Release Train is 70 and testing was requested only on beta (beta70). Manual qa was not requested for Nightly but only for Beta. I can update the PI with the correct testing environments if I get the correct information.

Yes, this should only be tested on 71

Comment 6

[Tom Ritter [:tjr]]

Attachment: Bug 1557074 - Enable process isolation for AMO and FXA on Nightly r?nika

And Nightly only, this isn't riding trains yet.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/c6cdd18f14022f0f808da0142b2180b3bef9b266
https://hg.mozilla.org/mozilla-central/rev/c6cdd18f1402

Not setting "Release-Track Client Security Bug" due to

And Nightly only, this isn't riding trains yet.

Comment 8

[Ioana Rusiczki]

Attachment: amo_fxa_process_isolation.csv

I tested on FF71 the attached test cases - AMO installs and fxA

I did not find regressions caused by enabling browser.tabs.remote.separatePrivilegedMozillaWebContentProcess (already on true on FF71).

AMO installs:
There would be some edge cases which are already known since they're reproducible on FF69 (in the relation between the detail pages on AMO and add-on Manager). I will discuss those with the AMO team.

FxA:
I noticed two issues and logged them but none of these are a regression caused by this issue. The fxA UI is going through some changes right now.

https://bugzilla.mozilla.org/show_bug.cgi?id=1585299
https://bugzilla.mozilla.org/show_bug.cgi?id=1585315

Comment 9

[Ioana Rusiczki]

@Tom Ritter <[e-mail]>

The only issue tracking these changes was this one which is verified on Nightly 71.
Also https://bugzilla.mozilla.org/show_bug.cgi?id=1539595 was closed on FF69 milestone. I believe it is no longer up to date.

A next step is the beta testing meaning I should send a preliminary status report on Nov 15, 2019.
The pref browser.tabs.remote.separatePrivilegedMozillaWebContentProcess is set on false on FF71.0b6.
Can qa start testing it by switching the pref on true? And will you open another bugzilla issue so the beta testing can be tracked too?

I believe this modification is going to land in FF71 - release? Or does it have another schedule?

Comment 10

[Tom Ritter [:tjr]]

(In reply to Ioana Rusiczki from comment #9)

@Tom Ritter <[e-mail]>

The only issue tracking these changes was this one which is verified on Nightly 71.
Also https://bugzilla.mozilla.org/show_bug.cgi?id=1539595 was closed on FF69 milestone. I believe it is no longer up to date.

A next step is the beta testing meaning I should send a preliminary status report on Nov 15, 2019.
The pref browser.tabs.remote.separatePrivilegedMozillaWebContentProcess is set on false on FF71.0b6.
Can qa start testing it by switching the pref on true? And will you open another bugzilla issue so the beta testing can be tracked too?

I believe this modification is going to land in FF71 - release? Or does it have another schedule?

We are holding this feature on Nightly for now. It will interact with other things that (I think) are Nightly only, so I do not think it is worth the time to test on Beta right now.