1557369 - Explicitly set extensions.htmlaboutaddons.recommendations.enabled=false in discopane tests

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Rob Wu [:robwu]]

The HTML discopane (bug 1546248) and the extension recommendations (bug 1550911) share the same internal logic for retrieving recommended extensions.

Tests that mock the discovery API (by assigning the URL of a test server to extensions.getAddons.discovery.api_url) should ensure that only one of the two is enabled. Otherwise an unexpected request can be triggered from a recommended extension section when the extension list view is opened, which causes a test to fail.

An example of a failing test is browser_html_discover_view_prefs.js. The test confirms that the discovery API isn't requested when the discovery pane is disabled. When the discopane is disabled, the next default view is the extension list. In XUL about:addons, there are no recommendations. However, when HTML about:addons is enabled, the test fails because of an unexpected request from the recommended extension section of the list view.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1557369 - Disable extension recommendations in discopane tests

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf3f5d7aa7b0
Disable extension recommendations in discopane tests r=mstriemer,zombie,mixedpuppy

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cf3f5d7aa7b0

Comment 4

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d04818deefae