Closed Bug 1557369 Opened 3 months ago Closed 3 months ago

Explicitly set extensions.htmlaboutaddons.recommendations.enabled=false in discopane tests

Categories

(Toolkit :: Add-ons Manager, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

Details

Attachments

(1 file)

The HTML discopane (bug 1546248) and the extension recommendations (bug 1550911) share the same internal logic for retrieving recommended extensions.

Tests that mock the discovery API (by assigning the URL of a test server to extensions.getAddons.discovery.api_url) should ensure that only one of the two is enabled. Otherwise an unexpected request can be triggered from a recommended extension section when the extension list view is opened, which causes a test to fail.

An example of a failing test is browser_html_discover_view_prefs.js. The test confirms that the discovery API isn't requested when the discovery pane is disabled. When the discopane is disabled, the next default view is the extension list. In XUL about:addons, there are no recommendations. However, when HTML about:addons is enabled, the test fails because of an unexpected request from the recommended extension section of the list view.

Flags: qe-verify-
Attachment #9070300 - Attachment description: Bug 1557369 - Disable extension recommendations in some tests → Bug 1557369 - Disable extension recommendations in discopane tests
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/cf3f5d7aa7b0
Disable extension recommendations in discopane tests r=mstriemer,zombie,mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.