1546248 - [about:addons] Create in-tree discopane to replace the remotely hosted discopane

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Rob Wu [:robwu]]

First step of bug 1540173 is to create the discopane in the HTML-based about:addons page in m-c.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1546248 - Add discopane to about:addons HTML view

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1546248 - Change "Get Add-ons" to "Recommendations"

Comment 3

[David Durst [:ddurst]]

Attachment: data collection review request

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1546248 - Add notice to discopane when TAAR is enabled

The <message-bar> custom element used in this patch will be
introduced by https://phabricator.services.mozilla.com/D27547

The notice text and SUMO link target were taken from
https://github.com/mozilla/addons-frontend/blob/6d2de7e52a2ff8d50d4ab1181974c39a3a7f1d8f/src/disco/pages/DiscoPane/index.js#L211-L213

Comment 5

[Rob Wu [:robwu]]

Attachment: Bug 1546248 - Put HTML discopane behind separate pref

Require extensions.htmlaboutaddons.discover.enabled to be enabled
before the HTML-based discopane is shown. This allows the feature
to be turned on and/or off independent of the other HTML views.

Comment 6

[Rob Wu [:robwu]]

Attachment: Bug 1546248 - Add attribution parameters to AMO links

Comment 7

[Chris H-C :chutten]

Comment on attachment 9061113 [details]
data collection review request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :ddurst is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+

Comment 8

[Rob Wu [:robwu]]

Attachment: Bug 1546248 - Loosen Client-ID check in unit test

The client_id part of browser_html_discover_view_clientid.js was failing
on TV because of a pre-existing, test-specific issue in Telemetry.
Fixing this is not trivial, so just check that the ID was set instead of
checking its exact value.

See the comment for more details; the fix will be part of bug 1537933

Comment 9

[Rob Wu [:robwu]]

Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7f88d2790160d6b318c164a92a0a9258a008992
Now pushing to integration.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afb54f703345
Add discopane to about:addons HTML view r=mstriemer,flod
https://hg.mozilla.org/integration/autoland/rev/0258f553e721
Change "Get Add-ons" to "Recommendations" r=mstriemer,flod
https://hg.mozilla.org/integration/autoland/rev/6c8b944ef465
Add notice to discopane when TAAR is enabled r=mstriemer,flod
https://hg.mozilla.org/integration/autoland/rev/75766279872a
Put HTML discopane behind separate pref r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/cb165c7bea67
Add attribution parameters to AMO links r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/b3f31aa87d0d
Loosen Client-ID check in unit test r=rpl

Comment 11

[Andreea Pavel [:apavel]]

backed out for not having a proper review peer.

Push that got backed out : https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b3f31aa87d0d11690a169368e39c8f07edf4ea88

Backout: https://hg.mozilla.org/integration/autoland/rev/2f3479842f9101fe2466775eaf777c728c289839

@Rob: since you landed multiple bugs in the same push, i backed out all of them.

Comment 12

[Rob Wu [:robwu]]

:jaws is a peer and delegated review to :mstriemer

https://phabricator.services.mozilla.com/D28436#873618
https://phabricator.services.mozilla.com/D29477#873632
https://phabricator.services.mozilla.com/D29478#873634
https://phabricator.services.mozilla.com/D29479#873636
https://phabricator.services.mozilla.com/D29480#873638
https://phabricator.services.mozilla.com/D29481#873644
https://phabricator.services.mozilla.com/D29482#873646

Can the patches land again, or I need to ask another peer to rubberstamp r+ every patch in Phabricator?

Comment 13

[Rob Wu [:robwu]]

Question was answered in #sheriffs . Landing those patches should have been fine.

Comment 14

[Andreea Pavel [:apavel]]

Is there something I need to do here?

Comment 15

[Rob Wu [:robwu]]

Hi Andreaa, thanks for keeping an eye on the bug.
Since soft freeze has been delayed, I will add another patch (telemetry) before landing them all. Likely within a day.

Comment 17

[Rob Wu [:robwu]]

Try is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c873d2cb4d2f321c833dd2441f300b9ead2246e8

I'll already land the existing patches so Mark can already rebase his patches on top of mine, and I'll add the telemetry patch later today.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1971986d9cd6
Add discopane to about:addons HTML view r=mstriemer,flod,aswan
https://hg.mozilla.org/integration/autoland/rev/23d7d4098ba3
Change "Get Add-ons" to "Recommendations" r=mstriemer,flod
https://hg.mozilla.org/integration/autoland/rev/76eb966c5aa7
Add notice to discopane when TAAR is enabled r=mstriemer,flod
https://hg.mozilla.org/integration/autoland/rev/53535f2ceb4c
Put HTML discopane behind separate pref r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/077dec75c81a
Add attribution parameters to AMO links r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/912b44cef0bc
Loosen Client-ID check in unit test r=rpl

Comment 19

[Rob Wu [:robwu]]

Attachment: Bug 1546248 - Add telemetry to discopane

This adds telemetry with new actions and link values to uniquely
identify interactions with the discovery pane and recommended add-on
cards.

The names are unique, because recommended add-on cards may also appear
in other views (bug 1523406).

Unrelated to this change, the documentation of "homepage" at Events.yaml
has been updated to clarify that it can also be a URL outside of AMO,
because that is the reality.

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1971986d9cd6
https://hg.mozilla.org/mozilla-central/rev/23d7d4098ba3
https://hg.mozilla.org/mozilla-central/rev/76eb966c5aa7
https://hg.mozilla.org/mozilla-central/rev/53535f2ceb4c
https://hg.mozilla.org/mozilla-central/rev/077dec75c81a
https://hg.mozilla.org/mozilla-central/rev/912b44cef0bc

Comment 21

[Intermittent Failures Robot]

3 failures in 4705 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• mozilla-central: 1
• mozilla-inbound: 1

Platform breakdown:

• osx-10-10: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1546248&startday=2019-05-06&endday=2019-05-12&tree=all

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04b9eaf2e439
Add telemetry to discopane r=rpl,chutten

Comment 23

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/04b9eaf2e439

Comment 24

[Intermittent Failures Robot]

2 failures in 4658 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• osx-10-10: 1
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1546248&startday=2019-05-13&endday=2019-05-19&tree=all

Comment 25

[CosminB]

Attachment: Bug1546248.gif

This issue is verified as fixed on Firefox 69.0a1 (20190523044159) and Firefox 68.0b3 (20190521110747) under Win 7 64-bit and Mac OS X 10.14.1.

• The preference extensions.htmlaboutaddons.discover.enabled is set to false by default.
  When the preference is set to false, the HTML-based discovery panel from about:addons is not enabled.

• "Get Add-ons" has been changed to "Recommendations"

• The links from the cards in the old and the new discopane work as expected.

• The notice from discopane is visible only when TAAR is enabled.

• In about:telemetry the events are:

  • Install from "Recommendations"
    {"action": "installFromRecommendation", "view": "discover", "addonId": "jid1-93WyvpgvxzGATw@jetpack", "type": "extension"}

  • Click on the “Manage” button
    {"action": "manage", "view": "discover", "addonId": "[e-mail]", "type": "extension"}

  • discohome (goes to AMO via a recommended add-on card)
    addonsManager link aboutAddons discohome {"view": "discover"}

  • discomore (goes to AMO via discover)
    addonsManager link aboutAddons discomore {"view": "discover"}

  • disconotice (goes to SUMO via discover)
    addonsManager link aboutAddons disconotice {"view": "discover"}

Please see the attached video.