1505909 - [Fission] Make the context menu Fission-aware

Reporter

Description

•

6 years ago

There were several test failures related to features in the context menu not working when using the browser.fission.simulate pref.

This bug will most likely need further break down later:

- Fixing the menu itself to correctly refer to the right originating frame
- Fixes for individual features of the context menu

Neha Kochar [:neha]

Updated

•

5 years ago

Fission Milestone: --- → Future

Neha Kochar [:neha]

Updated

•

5 years ago

Fission Milestone: Future → M3

Mike Conley (:mconley) (:⚙️)

Assignee

Updated

•

5 years ago

Assignee: nobody → mconley

Mike Conley (:mconley) (:⚙️)

Assignee

Updated

•

5 years ago

Depends on: 1553913

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 2

•

5 years ago

Attached file Bug 1505909 - Merge remote and non-remote context menu handlers. r?NeilDeakin — Details

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 3

•

5 years ago

Attached file Bug 1505909 - Stop sending a CPOW for the target element for context menu messages. r?MattN — Details

This introduces a new toolkit module, ContentDOMReference, which can generate identifiers
for DOM elements that can be safely passed across the process boundary without having to
use the CPOW infrastructure.

The Password Manager code seemed to be the only thing using the original CPOW, so this
has been updated to use the ContentDOMReference identifier instead.

Depends on D32757

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 4

•

5 years ago

Attached file Bug 1505909 - Make basic context menu actions Fission-compatible. r?NeilDeakin — Details

Depends on D32758

Mike Conley (:mconley) (:⚙️)

Assignee

Updated

•

5 years ago

Comment 5

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=914e06de23357816cf4e3d09aa4877d713fbb32b

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 6

•

5 years ago

I've got some desktop test failures still (mostly in the WebExtension suite), so looking at that next

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 7

•

5 years ago

Okay, got the tests passing locally, I think. Here's another try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=83e63ce32fcf1a7c72d067b3fa78f6a6b79634c6

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 8

•

5 years ago

Attached file Bug 1505909 - Update WebExtension menus API to use updated, Fission-aware ContextMenuChild. r?mixedpuppy — Details

Depends on D32876

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 9

•

5 years ago

Attached file Bug 1505909 - Make PlacesUIUtils.getViewForNode resilient against dead wrapper nodes. r?mak — Details

Depends on D33163

Mike Conley (:mconley) (:⚙️)

Assignee

Comment 10

•

5 years ago

Attached file Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r?mixedpuppy — Details

Depends on D33164

Pulsebot

Comment 11

•

5 years ago

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dbe6803d979e
Merge remote and non-remote context menu handlers. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/4aa17e28ee54
Stop sending a CPOW for the target element for context menu messages. r=MattN
https://hg.mozilla.org/integration/autoland/rev/8aeb77291207
Make basic context menu actions Fission-compatible. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/a1a2a9efe22f
Update WebExtension menus API to use updated, Fission-aware ContextMenuChild. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/3ff09b79821c
Make PlacesUIUtils.getViewForNode resilient against dead wrapper nodes. r=mak
https://hg.mozilla.org/integration/autoland/rev/56449fd37aee
Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag

Bogdan Tara[:bogdan_tara | bogdant]

Comment 12

•

5 years ago

Backed out 6 changesets (Bug 1505909) for bc failures complaining about WebNavigationChild and browser_e10s_about_page_triggeringprincipal.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=56449fd37aee9aaf1faf0aeefab2cd80d6c20d03&tochange=a313214fd6486359816abe95d5c15603062a3c0c&selectedJob=250525409

Backout link: https://hg.mozilla.org/integration/autoland/rev/a313214fd6486359816abe95d5c15603062a3c0c

Failures log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250525409&repo=autoland&lineNumber=7320

[task 2019-06-07T02:12:06.092Z] 02:12:06 [task 2019-06-07T02:12:06.154Z] 02:12:06 [task 2019-06-07T02:12:06.154Z] 02:12:06 [task 2019-06-07T02:12:06.170Z] 02:12:06 [task 2019-06-07T02:12:06.279Z] 02:12:06 [task 2019-06-07T02:12:06.522Z] 02:12:06 ...
[task 2019-06-07T02:12:08.110Z] 02:12:08 [task 2019-06-07T02:12:08.110Z] 02:12:08 [task 2019-06-07T02:12:08.110Z] 02:12:08 [task 2019-06-07T02:12:08.111Z] 02:12:08 [task 2019-06-07T02:12:08.111Z] 02:12:08 [task 2019-06-07T02:12:08.111Z] 02:12:08 [task 2019-06-07T02:12:08.111Z] 02:12:08 [task 2019-06-07T02:12:08.111Z] 02:12:08 [task 2019-06-07T02:12:08.113Z] 02:12:08 [task 2019-06-07T02:12:08.113Z] 02:12:08 [task 2019-06-07T02:12:08.246Z] 02:12:08 [task 2019-06-07T02:12:08.246Z] 02:12:08 [task 2019-06-07T02:12:08.246Z] 02:12:08 [task 2019-06-07T02:12:08.247Z] 02:12:08 [task 2019-06-07T02:12:08.249Z] 02:12:08 ...
[task 2019-06-07T02:13:36.302Z] 02:13:36 [task 2019-06-07T02:13:36.303Z] 02:13:36 [task 2019-06-07T02:13:36.303Z] 02:13:36 [task 2019-06-07T02:13:36.304Z] 02:13:36 [task 2019-06-07T02:13:36.304Z] 02:13:36 [task 2019-06-07T02:13:36.304Z] 02:13:36 [task 2019-06-07T02:13:36.304Z] 02:13:36 [task 2019-06-07T02:13:36.304Z] 02:13:36 [task 2019-06-07T02:13:36.304Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.306Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.307Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.309Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.310Z] 02:13:36 [task 2019-06-07T02:13:36.312Z] 02:13:36 [task 2019-06-07T02:13:36.312Z] 02:13:36 [task 2019-06-07T02:13:36.312Z] 02:13:36 [task 2019-06-07T02:13:36.313Z] 02:13:36 [task 2019-06-07T02:13:36.313Z] 02:13:36 [task 2019-06-07T02:13:36.313Z] 02:13:36 [task 2019-06-07T02:13:36.313Z] 02:13:36 [task 2019-06-07T02:13:36.313Z] 02:13:36 [task 2019-06-07T02:13:36.315Z] 02:13:36 [task 2019-06-07T02:13:36.351Z] 02:13:36 [task 2019-06-07T02:13:36.392Z] 02:13:36 INFO - TEST-START | browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js
INFO - GECKO(2122) | ++DOCSHELL 0x127791800 == 9 [pid = 2122] [id = {d16e9d25-8078-9f4c-bfa7-99196ec206f7}]
INFO - GECKO(2122) | ++DOMWINDOW == 29 (0x138a4d3e0) [pid = 2122] [serial = 41] [outer = 0x0]
INFO - GECKO(2122) | ++DOMWINDOW == 30 (0x1349c3400) [pid = 2122] [serial = 42] [outer = 0x138a4d3e0]
INFO - GECKO(2122) | ++DOMWINDOW == 31 (0x136e08800) [pid = 2122] [serial = 43] [outer = 0x138a4d3e0]
INFO - GECKO(2122) | ++DOCSHELL 0x126bbf800 == 4 [pid = 2124] [id = {2fbc4b3b-31d0-2d42-a2fe-4f1dbbb4dcd7}]
INFO - GECKO(2122) | [Child 2124, Main Thread] WARNING: We need a triggering principal to continue loading - assert@resource://gre/actors/WebNavigationChild.jsm:144:33
INFO - GECKO(2122) | loadURI@resource://gre/actors/WebNavigationChild.jsm:116:10
INFO - GECKO(2122) | receiveMessage@resource://gre/actors/WebNavigationChild.jsm:39:14
INFO - GECKO(2122) | receiveMessage@resource://gre/modules/ActorManagerChild.jsm:165:30
INFO - GECKO(2122) | MessageListener.receiveMessageinit@resource://gre/modules/ActorManagerChild.jsm:53:15
INFO - GECKO(2122) | attach@resource://gre/modules/ActorManagerChild.jsm:317:48
INFO - GECKO(2122) | @chrome://gl
INFO - GECKO(2122) | [Child 2124, Main Thread] ###!!! ABORT: file WebNavigationChild.js, line 116
INFO - GECKO(2122) | [Child 2124, Main Thread] ###!!! ABORT: file WebNavigationChild.js, line 116
INFO - GECKO(2122) | Hit MOZ_CRASH() at /builds/worker/workspace/build/src/memory/mozalloc/mozalloc_abort.cpp:33
INFO - GECKO(2122) | --DOMWINDOW == 12 (0x12ce50980) [pid = 2130] [serial = 15] [outer = 0x0] [url = http://mochi.test:8888/]
INFO - GECKO(2122) | --DOMWINDOW == 11 (0x12ce50020) [pid = 2130] [serial = 12] [outer = 0x0] [url = about:blank]
INFO - GECKO(2122) | [Parent 2122, Main Thread] WARNING: IPC message discarded: actor cannot send: file /builds/worker/workspace/build/src/ipc/glue/ProtocolUtils.cpp, line 568
INFO - GECKO(2122) | ++DOCSHELL 0x12f47e800 == 12 [pid = 2122] [id = {addcbf07-fd94-0046-8483-f73b85b79c33}]
INFO - GECKO(2122) | ++DOMWINDOW == 38 (0x1336e3e20) [pid = 2122] [serial = 50] [outer = 0x0]
INFO - Entering test bound test_principal_right_click_open_link_in_new_tab
INFO - Console message: [JavaScript Warning: "Sending message that cannot be cloned. Are you trying to send an XPCOM object?" {file: "resource:///actors/ContextMenuChild.jsm" line: 599}]
INFO - Buffered messages logged at 02:12:08
INFO - Console message: [JavaScript Error: "E10SUtils: Failed to deserialize referrerInfo_b64 '[object Object]' [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsISerializationHelper.deserializeObject]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/E10SUtils.jsm :: deserializeReferrerInfo :: line 611" data: no]" {file: "resource://gre/modules/E10SUtils.jsm" line: 32}]
INFO - debug@resource://gre/modules/E10SUtils.jsm:32:18
INFO - deserializeReferrerInfo@resource://gre/modules/E10SUtils.jsm:614:9
INFO - openContextMenu@chrome://browser/content/nsContextMenu.js:61:55
INFO - receiveMessage@resource:///actors/ContextMenuParent.jsm:23:9
INFO -
INFO - Console message: [JavaScript Error: "E10SUtils: Failed to serialize principal '[object Object]' [Exception... "Failure arg 0 [nsIScriptSecurityManager.principalToJSON]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: resource://gre/modules/E10SUtils.jsm :: serializePrincipal :: line 387" data: no]" {file: "resource://gre/modules/E10SUtils.jsm" line: 32}]
INFO - debug@resource://gre/modules/E10SUtils.jsm:32:18
INFO - serializePrincipal@resource://gre/modules/E10SUtils.jsm:390:7
INFO - loadURI@resource://gre/modules/RemoteWebNavigation.jsm:116:38
INFO - _loadURI@chrome://browser/content/browser.js:1249:29
INFO - addTab@chrome://browser/content/tabbrowser.js:2592:11
INFO - loadOneTab@chrome://browser/content/tabbrowser.js:1451:20
INFO - openLinkIn@chrome://browser/content/utilityOverlay.js:561:37
INFO - openLinkInTab@chrome://browser/content/nsContextMenu.js:829:5
INFO - oncommand@chrome://browser/content/browser.xhtml:1:14
INFO - test_principal_right_click_open_link_in_new_tab/</<@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js:96:56
INFO - listener@resource://testing-common/BrowserTestUtils.jsm:890:27
INFO - EventListener.handleEventwaitForEvent/<@resource://testing-common/BrowserTestUtils.jsm:888:15
INFO - waitForEvent@resource://testing-common/BrowserTestUtils.jsm:887:12
INFO - test_principal_right_click_open_link_in_new_tab/<@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js:94:22
INFO - withNewTab@resource://testing-common/BrowserTestUtils.jsm:111:24
INFO - asynctest_principal_right_click_open_link_in_new_tab@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js:90:26
INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1115:34
INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1143:12
INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1004:14
INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
INFO -
INFO - Console message: [JavaScript Error: "remote browser crashed while on about:blank
INFO - " {file: "chrome://mochikit/content/mochitest-e10s-utils.js" line: 8}]
INFO - e10s_init/<@chrome://mochikit/content/mochitest-e10s-utils.js:8:8
INFO - EventListener.handleEvente10s_init@chrome://mochikit/content/mochitest-e10s-utils.js:6:10
INFO - testInit@chrome://mochikit/content/browser-test.js:105:5
INFO - setTimeout handler*@chrome://mochikit/content/browser-test.js:23:1
INFO - loadChromeScripts@jar:file:///var/folders/jw/trqrfq6103l2x0cr9n16qh1c00000w/T/tmpfS_mrP.mozrunner/extensions/mochikit@mozilla.org.xpi!/api.js:13:25
INFO - loadMochitest@jar:file:///var/folders/jw/trqrfq6103l2x0cr9n16qh1c00000w/T/tmpfS_mrP.mozrunner/extensions/mochikit@mozilla.org.xpi!/api.js:112:3
INFO - @tests/mochitest/runtests.py:1783:5
INFO - @tests/mochitest/runtests.py:1784:8
INFO - evaluate.sandbox/promise<@chrome://marionette/content/evaluate.js:128:10
INFO - evaluate.sandbox@chrome://marionette/content/evaluate.js:106:17
INFO - GeckoDriver.prototype.execute@chrome://marionette/content/driver.js:1029:28
INFO - async*GeckoDriver.prototype.executeScript@chrome://marionette/content/driver.js:911:29
INFO - despatch@chrome://marionette/content/server.js:289:40
INFO - execute@chrome://marionette/content/server.js:262:16
INFO - onPacket/<@chrome://marionette/content/server.js:235:20
INFO - onPacket@chrome://marionette/content/server.js:236:9
INFO - _onJSONObjectReady/<@chrome://marionette/content/transport.js:492:20
INFO -
INFO - Buffered messages finished
INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js | Test timed out -
INFO - GECKO(2122) | MEMORY STAT | vsize 5522MB | residentFast 348MB | heapAllocated 91MB
INFO - TEST-OK | browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js | took 90067ms
INFO - Not taking screenshot here: see the one that was previously logged
INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js | Found a tab after previous test timed out: about:blank -
INFO - Not taking screenshot here: see the one that was previously logged
INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js | Found a tab after previous test timed out: about:test-about-principal-parent -
INFO - GECKO(2122) | [Child 2130, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
INFO - GECKO(2122) | [Parent 2122, Main Thread] WARNING: NS_ENSURE_TRUE(mDoneSetup) failed: file /builds/worker/workspace/build/src/editor/composer/nsEditingSession.cpp, line 1190
INFO - GECKO(2122) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/jw/trqrfq6103l2x0cr9n16qh1c00000w/T/tmpfS_mrP.mozrunner/runtests_leaks_tab_pid2158.log
INFO - checking window state
INFO - TEST-START | browser/base/content/test/tabs/browser_e10s_about_process.js

Flags: needinfo?(mconley)

Bogdan Tara[:bogdan_tara | bogdant]

Comment 13

•

5 years ago

Another failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250530109&repo=autoland&lineNumber=23277

[task 2019-06-07T02:13:35.236Z] 02:13:35 INFO - TEST-START | dom/security/test/general/browser_test_view_image_data_navigation.js
[task 2019-06-07T02:13:35.238Z] 02:13:35 INFO - GECKO(3548) | Chrome file doesn't exist: Z:\task_1559865802\build\tests\mochitest\browser\dom\security\test\general\head.js
[task 2019-06-07T02:13:35.257Z] 02:13:35 INFO - GECKO(3548) | ++DOCSHELL 000001976069B800 == 14 [pid = 4340] [id = {1ae50d85-748b-4aac-8ac1-09ff3d4ee35c}]
[task 2019-06-07T02:13:35.257Z] 02:13:35 INFO - GECKO(3548) | ++DOMWINDOW == 34 (000001976D561880) [pid = 4340] [serial = 34] [outer = 0000000000000000]
[task 2019-06-07T02:13:35.259Z] 02:13:35 INFO - GECKO(3548) | ++DOMWINDOW == 35 (0000019760D4EC00) [pid = 4340] [serial = 35] [outer = 000001976D561880]
[task 2019-06-07T02:13:35.341Z] 02:13:35 INFO - GECKO(3548) | ++DOMWINDOW == 36 (0000019768370800) [pid = 4340] [serial = 36] [outer = 000001976D561880]
[task 2019-06-07T02:13:35.441Z] 02:13:35 INFO - GECKO(3548) | --DOCSHELL 0000023A1EA24800 == 5 [pid = 6876] [id = {4caebbd9-ab99-48d7-b025-77fae34efce6}] [url = about:blank]
[task 2019-06-07T02:13:35.441Z] 02:13:35 INFO - GECKO(3548) | --DOCSHELL 0000023A1D5D9000 == 4 [pid = 6876] [id = {acd9f4c5-b64d-4d61-9cfa-93ae8644682a}] [url = about:blank]
[task 2019-06-07T02:13:35.441Z] 02:13:35 INFO - GECKO(3548) | --DOCSHELL 0000023A1D547800 == 3 [pid = 6876] [id = {cfee1878-7642-4ab2-b55f-13d72eeabccb}] [url = data:text/html,<iframe src="ftp://blocked.test/c.html"></iframe>]
[task 2019-06-07T02:13:35.441Z] 02:13:35 INFO - GECKO(3548) | --DOCSHELL 0000023A1D544000 == 2 [pid = 6876] [id = {577e9de8-3a72-43cd-98a2-929e5aea178e}] [url = about:srcdoc]
[task 2019-06-07T02:13:35.442Z] 02:13:35 INFO - GECKO(3548) | --DOCSHELL 0000023A1D543800 == 1 [pid = 6876] [id = {c16b6578-abc4-45a7-80a2-c311e0b2b578}] [url = about:blank]
[task 2019-06-07T02:13:35.442Z] 02:13:35 INFO - GECKO(3548) | --DOCSHELL 0000023A1574B000 == 0 [pid = 6876] [id = {b8c20cd3-7b84-4d11-a616-d5d540482512}] [url = http://mochi.test:8888/browser/dom/security/test/general/file_FTP_console_warning.html]
[task 2019-06-07T02:13:35.501Z] 02:13:35 INFO - GECKO(3548) | --DOMWINDOW == 14 (0000023A1D5F4A60) [pid = 6876] [serial = 6] [outer = 0000000000000000] [url = about:srcdoc]
[task 2019-06-07T02:13:35.502Z] 02:13:35 INFO - GECKO(3548) | --DOMWINDOW == 13 (0000023A1D5F4880) [pid = 6876] [serial = 5] [outer = 0000000000000000] [url = about:blank]
[task 2019-06-07T02:13:35.502Z] 02:13:35 INFO - GECKO(3548) | --DOMWINDOW == 12 (0000023A1D5F4C40) [pid = 6876] [serial = 7] [outer = 0000000000000000] [url = data:text/html,<iframe src="ftp://blocked.test/c.html"></iframe>]
[task 2019-06-07T02:13:35.502Z] 02:13:35 INFO - GECKO(3548) | --DOMWINDOW == 11 (0000023A1EA5E200) [pid = 6876] [serial = 14] [outer = 0000000000000000] [url = about:blank]
[task 2019-06-07T02:13:35.502Z] 02:13:35 INFO - GECKO(3548) | --DOMWINDOW == 10 (0000023A1EA236A0) [pid = 6876] [serial = 12] [outer = 0000000000000000] [url = about:blank]
[task 2019-06-07T02:13:35.628Z] 02:13:35 INFO - GECKO(3548) | [Parent 4340, Main Thread] WARNING: 'aRv.Failed()', file z:/build/build/src/dom/ipc/StructuredCloneData.cpp, line 120
[task 2019-06-07T02:13:35.650Z] 02:13:35 INFO - GECKO(3548) | [Parent 4340, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file z:/build/build/src/netwerk/base/nsSerializationHelper.cpp, line 33
[task 2019-06-07T02:13:35.790Z] 02:13:35 INFO - TEST-INFO | started process screenshot
[task 2019-06-07T02:13:35.869Z] 02:13:35 INFO - TEST-INFO | screenshot: exit 0
[task 2019-06-07T02:13:35.869Z] 02:13:35 INFO - Buffered messages logged at 02:13:35
[task 2019-06-07T02:13:35.869Z] 02:13:35 INFO - Entering test bound test_principal_right_click_open_link_in_new_tab
[task 2019-06-07T02:13:35.869Z] 02:13:35 INFO - Console message: [JavaScript Warning: "Sending message that cannot be cloned. Are you trying to send an XPCOM object?" {file: "resource:///actors/ContextMenuChild.jsm" line: 599}]
[task 2019-06-07T02:13:35.870Z] 02:13:35 INFO - Global property added while loading chrome://browser/content/nsContextMenu.js: gContextMenuContentData
[task 2019-06-07T02:13:35.870Z] 02:13:35 INFO - Global property added while loading chrome://browser/content/nsContextMenu.js: SpellCheckHelper
[task 2019-06-07T02:13:35.870Z] 02:13:35 INFO - Global property added while loading chrome://browser/content/nsContextMenu.js: LoginManagerContextMenu
[task 2019-06-07T02:13:35.870Z] 02:13:35 INFO - Global property added while loading chrome://browser/content/nsContextMenu.js: DevToolsShim
[task 2019-06-07T02:13:35.870Z] 02:13:35 INFO - Console message: [JavaScript Error: "E10SUtils: Failed to deserialize referrerInfo_b64 '[object Object]' [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsISerializationHelper.deserializeObject]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource://gre/modules/E10SUtils.jsm :: deserializeReferrerInfo :: line 611" data: no]" {file: "resource://gre/modules/E10SUtils.jsm" line: 32}]
[task 2019-06-07T02:13:35.870Z] 02:13:35 INFO - debug@resource://gre/modules/E10SUtils.jsm:32:18
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - deserializeReferrerInfo@resource://gre/modules/E10SUtils.jsm:614:9
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - openContextMenu@chrome://browser/content/nsContextMenu.js:61:55
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - receiveMessage@resource:///actors/ContextMenuParent.jsm:23:9
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO -
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - Buffered messages finished
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/browser_test_view_image_data_navigation.js | uncaught exception - Error: Load of data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIxNiIgaGVpZ2h0PSIxNiIgdmlld0JveD0iMCAwIDE2IDE2Ij4KICA8cGF0aCBkPSJNOCwxMkwzLDcsNCw2bDQsNCw0LTQsMSwxWiIgZmlsbD0iIzZBNkE2QSIgLz4KPC9zdmc+Cg== denied. at urlSecurityCheck@resource://gre/modules/BrowserUtils.jsm:77:13
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - urlSecurityCheck@chrome://global/content/contentAreaUtils.js:30:23
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - viewMedia@chrome://browser/content/nsContextMenu.js:959:7
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - oncommand@chrome://browser/content/browser.xhtml:1:14
[task 2019-06-07T02:13:35.871Z] 02:13:35 INFO - test_principal_right_click_open_link_in_new_tab/</<@chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:16:52
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - listener@resource://testing-common/BrowserTestUtils.jsm:890:27
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - EventListener.handleEventwaitForEvent/<@resource://testing-common/BrowserTestUtils.jsm:888:15
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - waitForEvent@resource://testing-common/BrowserTestUtils.jsm:887:12
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - test_principal_right_click_open_link_in_new_tab/<@chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:14:22
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - withNewTab@resource://testing-common/BrowserTestUtils.jsm:111:24
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - asynctest_principal_right_click_open_link_in_new_tab@chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:10:26
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1115:34
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1143:12
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1004:14
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO -
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - Stack trace:
[task 2019-06-07T02:13:35.872Z] 02:13:35 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1665
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:test_principal_right_click_open_link_in_new_tab/</<:16
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - resource://testing-common/BrowserTestUtils.jsm:listener:890
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - EventListener.handleEventresource://testing-common/BrowserTestUtils.jsm:waitForEvent/<:888
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - resource://testing-common/BrowserTestUtils.jsm:waitForEvent:887
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:test_principal_right_click_open_link_in_new_tab/<:14
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:111
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:test_principal_right_click_open_link_in_new_tab:10
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1004
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-06-07T02:13:35.873Z] 02:13:35 INFO - GECKO(3548) | JavaScript error: resource://gre/modules/BrowserUtils.jsm, line 77: Error: Load of data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIxNiIgaGVpZ2h0PSIxNiIgdmlld0JveD0iMCAwIDE2IDE2Ij4KICA8cGF0aCBkPSJNOCwxMkwzLDcsNCw2bDQsNCw0LTQsMSwxWiIgZmlsbD0iIzZBNkE2QSIgLz4KPC9zdmc+Cg== denied.
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - Console message: [JavaScript Error: "Error: Load of data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIxNiIgaGVpZ2h0PSIxNiIgdmlld0JveD0iMCAwIDE2IDE2Ij4KICA8cGF0aCBkPSJNOCwxMkwzLDcsNCw2bDQsNCw0LTQsMSwxWiIgZmlsbD0iIzZBNkE2QSIgLz4KPC9zdmc+Cg== denied." {file: "resource://gre/modules/BrowserUtils.jsm" line: 77}]
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - urlSecurityCheck@resource://gre/modules/BrowserUtils.jsm:77:13
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - urlSecurityCheck@chrome://global/content/contentAreaUtils.js:30:23
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - viewMedia@chrome://browser/content/nsContextMenu.js:959:7
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - oncommand@chrome://browser/content/browser.xhtml:1:14
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - test_principal_right_click_open_link_in_new_tab/</<@chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:16:52
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - listener@resource://testing-common/BrowserTestUtils.jsm:890:27
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - EventListener.handleEventwaitForEvent/<@resource://testing-common/BrowserTestUtils.jsm:888:15
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - waitForEvent@resource://testing-common/BrowserTestUtils.jsm:887:12
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - test_principal_right_click_open_link_in_new_tab/<@chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:14:22
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - withNewTab@resource://testing-common/BrowserTestUtils.jsm:111:24
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - asynctest_principal_right_click_open_link_in_new_tab@chrome://mochitests/content/browser/dom/security/test/general/browser_test_view_image_data_navigation.js:10:26
[task 2019-06-07T02:13:35.874Z] 02:13:35 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1115:34
[task 2019-06-07T02:13:35.875Z] 02:13:35 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1143:12
[task 2019-06-07T02:13:35.875Z] 02:13:35 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1004:14
[task 2019-06-07T02:13:35.875Z] 02:13:35 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
[task 2019-06-07T02:13:35.875Z] 02:13:35 INFO -

Pulsebot

Comment 14

•

5 years ago

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e31f9726798
Merge remote and non-remote context menu handlers. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/40f0a56ed3af
Stop sending a CPOW for the target element for context menu messages. r=MattN
https://hg.mozilla.org/integration/autoland/rev/afc11a5ebb6d
Make basic context menu actions Fission-compatible. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/bcca6bb913ef
Update WebExtension menus API to use updated, Fission-aware ContextMenuChild. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/8adcacadd689
Make PlacesUIUtils.getViewForNode resilient against dead wrapper nodes. r=mak
https://hg.mozilla.org/integration/autoland/rev/57336967a6c7
Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag

Noemi Erli[:noemi_erli]

Comment 15

•

5 years ago

Backed out 6 changesets (Bug 1505909) for failures in browser_ext_webNavigation_onCreatedNavigationTarget_contextmenu.js CLOSED TREE

Push with failures : https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=894a44c472727258338f2d013243c9b821a62686&searchStr=browser-chrome

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250624442&repo=autoland&lineNumber=23101

Backout: https://hg.mozilla.org/integration/autoland/rev/d83d3b37c2b8cd637fe36568697b9515343247d9

Mike Conley (:mconley) (:⚙️)

Assignee

Updated

•

5 years ago

Comment 16

•

5 years ago

Try push this time: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f81f4e2b8235525fea138fb1f5c016888c559252

Pulsebot

Comment 17

•

5 years ago

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecba465c6a02
Merge remote and non-remote context menu handlers. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/c5c598ace743
Stop sending a CPOW for the target element for context menu messages. r=MattN
https://hg.mozilla.org/integration/autoland/rev/adc60720b7b8
Make basic context menu actions Fission-compatible. r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/7b28b3478c36
Update WebExtension menus API to use updated, Fission-aware ContextMenuChild. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/4848a4ed198d
Make PlacesUIUtils.getViewForNode resilient against dead wrapper nodes. r=mak
https://hg.mozilla.org/integration/autoland/rev/d08ae3b73857
Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag

Narcis Beleuzu [:NarcisB]

Comment 18

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ecba465c6a02
https://hg.mozilla.org/mozilla-central/rev/c5c598ace743
https://hg.mozilla.org/mozilla-central/rev/adc60720b7b8
https://hg.mozilla.org/mozilla-central/rev/7b28b3478c36
https://hg.mozilla.org/mozilla-central/rev/4848a4ed198d
https://hg.mozilla.org/mozilla-central/rev/d08ae3b73857

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox69: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 69

Mike Conley (:mconley) (:⚙️)

Assignee

Updated

•

5 years ago

Flags: needinfo?(mconley)

Brad Werth [:bradwerth]

Updated

•

5 years ago

Regressions: 1558337

Luca Greco [:rpl] [:luca] [:lgreco]

Updated

•

5 years ago

Regressions: 1558506

Kris Maglione [:kmag]

Updated

•

5 years ago

Blocks: 1560166

Julian Descottes [:jdescottes]

Updated

•

5 years ago

Regressions: 1486717

Luca Greco [:rpl] [:luca] [:lgreco]

Updated

•

5 years ago

Blocks: 1549450

Nika Layzell [:nika] (ni? for response)

Updated

•

5 years ago

Regressions: 1576565

Mike Conley (:mconley) (:⚙️)

Assignee

Updated

•

5 years ago

Updated

•

4 years ago

Regressions: 1635106

:Gijs (he/him)

Updated

•

3 years ago

Regressions: 1701152

Alice0775 White

Updated

•

3 years ago

Regressions: 1701843

Bug 1505909 - Merge remote and non-remote context menu handlers. r?NeilDeakin 5 years ago Mike Conley (:mconley) (:⚙️) 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1505909 - Stop sending a CPOW for the target element for context menu messages. r?MattN 5 years ago Mike Conley (:mconley) (:⚙️) 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1505909 - Make basic context menu actions Fission-compatible. r?NeilDeakin 5 years ago Mike Conley (:mconley) (:⚙️) 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1505909 - Update WebExtension menus API to use updated, Fission-aware ContextMenuChild. r?mixedpuppy 5 years ago Mike Conley (:mconley) (:⚙️) 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1505909 - Make PlacesUIUtils.getViewForNode resilient against dead wrapper nodes. r?mak 5 years ago Mike Conley (:mconley) (:⚙️) 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r?mixedpuppy 5 years ago Mike Conley (:mconley) (:⚙️) 47 bytes, text/x-phabricator-request		Details \| Review