1558065 - [X11][Basic] Titlebar has sharp white corners instead of rounded

Status: RESOLVED DUPLICATE of bug 1460959

(Core :: Widget: Gtk, defect, P3)

Description

[carlosjosepita]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.80 Safari/537.36

Steps to reproduce:

Install firefox 67.0.1 in Ubuntu 19.04 or Arch Linux. Set Yaru or Adwaita-dark gtk themes. Remove titlebars from firefox. Look at the headerbar top edges.

Actual results:

The edges should be rounded in these themes. Nevertheless Firefox shows pointy edges. Much worse, they are of a different color than the rounded part (which is very notorious with dark themes, specially Yaru). This has been reported, fixed, broken again, reported again, fixed again and, apparently, broken again now (67).

Expected results:

Rounded edges as the theme require.

TBH these recurring regressions surprise me because Yaru+Ubuntu and Adwaita+Gnome should be important targets for Firefox.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Which DE do you use? Gnome-shell or something else? Also do you run Wayland or X11 session? All those are factors due to various Gtk bugs.

Comment 2

[Kestrel]

I see this on Ubuntu 19.04 with X11 and Basic compositor but CSD is not default-enabled indicating it is not well supported on this configuration. It can be fixed by turning on OpenGL (layers.acceleration.force-enabled = true) or WebRender (gfx.webrender.all = true) or using Wayland.

Comment 3

[3ship]

I can confirm I have the same issue.

Manjaro GNOME, X11
Firefox 67.0.2, fresh profile

Comment 4

[Martin Stránský [:stransky] (ni? me)]

That's weird as shape mask should be used there. Can you attach output of "env | grep XDG" and also your about:config?

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Also I expect it's still broken with latest nightly, right?

Comment 6

[Kestrel]

Comment 2 is still applicable with latest Nightly 71.0a1 (2019-10-03).

XDG is just stock x11 ubuntu:GNOME and the prefs.js produced by a new profile contains nothing relevant.

XDG_CONFIG_DIRS=/etc/xdg/xdg-ubuntu:/etc/xdg
XDG_MENU_PREFIX=gnome-
XDG_SEAT=seat0
XDG_SESSION_DESKTOP=ubuntu
XDG_SESSION_TYPE=x11
XDG_CURRENT_DESKTOP=ubuntu:GNOME
XDG_SESSION_CLASS=user
XDG_VTNR=2
XDG_SESSION_ID=1
XDG_RUNTIME_DIR=/run/user/1000
XDG_DATA_DIRS=/usr/share/ubuntu:/usr/local/share/:/usr/share/:/var/lib/snapd/desktop:/var/lib/snapd/desktop

Comment 7

[Kestrel]

Attachment: Titlebar with white corners on X11 with Basic compositor

Comment 8

[Kestrel]

It appears the shape mask was intentionally disabled on X.

and disable titlebar X shape mask on mutter/X.org

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=69f963484c0750fcaf37e151b5c910f7ebff9c25&tochange=dbf19d7364137fd04c36f04086f3445c020d2c99

Regressed by Bug 1530625.

Manually creating mozilla.widget.use-argb-visuals = true makes the corners transparent.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Yes, but mozilla.widget.use-argb-visuals = true also introduces Bug 1516224. But maybe Bug 1516224 is not longer an issue with Bug 1578464 checked in.

Comment 10

[Pascal Chevrel:pascalc]

Marking as fix-optional for 71 as we are entering the beta cycle. I would consider a safe patch for uplift in early betas though.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

I'll look at it. We need to make sure it works under X11 and XWayland on Gnome.