Closed Bug 1558124 Opened 5 years ago Closed 5 years ago

Add support for AudioWorkletNode.onprocessorerror

Categories

(Core :: Web Audio, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox69 --- wontfix
firefox76 --- fixed

People

(Reporter: karlt, Assigned: padenot)

References

(Regressed 1 open bug)

Details

Attachments

(7 files, 1 obsolete file)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

https://webaudio.github.io/web-audio-api/#dom-audioworkletnode-onprocessorerror

When an exception is thrown from the processor’s constructor, process method, or any user-defined class method, the processor will queue a task on the control thread to fire onprocessorerror event to the node.

Blocks: 1616725
Assignee: nobody → padenot

Having nested AutoJSAPI clobbers the exception value of the innermost one on
destruction.

Those are needed, respectively to be able to ensure the stream doesn't go away
when messaging back to the control thread, and then to access the details of the
exception thrown.

I don't really understand why yet, but in WPT, the file, line and column are not reported correctly.

Blocks: 1473176
See Also: → 1623226
Regressions: 1623230

Comment on attachment 9134138 [details]
Bug 1558124 - Update test_audioWorkletGlobalScopeRegisterProcessor.html with new error messages and error type. r?karlt

Revision D67326 was moved to bug 1565464. Setting attachment 9134138 [details] to obsolete.

Attachment #9134138 - Attachment is obsolete: true
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/82a790408f9b Pass a JSContext to AudioWorkletGlobalScope::ConstructProcessor. r=karlt https://hg.mozilla.org/integration/autoland/rev/23e341cbee7f Don't suppress the exception when the ctor of an AudioWorkletProcessor throws. r=karlt https://hg.mozilla.org/integration/autoland/rev/cfe8f7aab169 Pass the track and the JSContext to SendProcessorError. r=karlt https://hg.mozilla.org/integration/autoland/rev/1f8bd600d0dc When an exception happens in the AudioWorkletGlobalScope, fire `onprocessorerror`. r=karlt https://hg.mozilla.org/integration/autoland/rev/3632d18388cb Adjust WPT expectations after implementation of `AudioWorkletNode.onprocessorerror`. r=karlt https://hg.mozilla.org/integration/autoland/rev/907dd6c366e7 When calling the AudioWorkletProcessor ctor, switch to rethrowing exceptions to handle them manually. r=karlt https://hg.mozilla.org/integration/autoland/rev/c5b0bcb5bc5b Check the type of the error passed to onprocessorerror in WPT. r=karlt
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22320 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

(In reply to Paul Adenot (:padenot) from comment #8)

I don't really understand why yet, but in WPT, the file, line and column are not reported correctly.

Bug 1623226 is the same issue.

Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: