1558183 - Prompt displayed before install in about:addons

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[CosminB]

Attachment: Prompt.gif

[Affected versions]:

• Firefox 69.0a1 (20190609214350)
• Firefox 68.0b8 (20190606101422)

[Affected platforms]:

• Win 7 64-bit
• Mac OS X 10.14.1

[Prerequisites]

• Set extensions.htmlaboutaddons.discover.enabled to true
• Set extensions.htmlaboutaddons.enabled to true

[Steps to reproduce]:
1.Install an extension or theme from “Recommendations”.

[Expected results]:

• There is no prompt displayed before the install.

[Actual results]:

• The confirmation prompt before the install is displayed.

Please see the attached video.

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1539598#c17 there should be no prompt displayed from "Recommendations" before the install

I did a regression window and I think that Bug 1546248 is the one that caused this regression.

Last good revision: 9f769e825727a431a5412de163382902707a3e1d
First bad revision: 912b44cef0bcf2ddf29778ee2f5d8586933095af
Pushlog:https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9f769e825727a431a5412de163382902707a3e1d&tochange=912b44cef0bcf2ddf29778ee2f5d8586933095af

Comment 1

[Rob Wu [:robwu]]

This is an intentional change.

Besides this, there is also another difference: Previously, the preview image could be clicked and the theme would install without confirmation. With bug 1546248, clicking the preview has no effect, and clicking the install button will (as you have discovered) result in a prompt before it is installed.