1558298 - Cleanup SpecialPowers

Status: RESOLVED FIXED

(Testing :: Mochitest, task, P2)

Description

[Kris Maglione [:kmag]]

SpecialPowers is kind of a mess right now, which makes it difficult to refactor it for Fission support.

A lot of unrelated code is pretty heavily intertwined, which makes it difficult to find all of the code that needs to changed.

Possibly more importantly, though, the same code is loaded into all sorts of different contexts (as a JSM, into a chrome window using a <script> tag, into a plain object using the subscript loader, ...), with various hacks to make things continue working. That makes it pretty hard to tell what is used where, and causes some changes that assume a script is actually being loaded as, e.g., a frame script or a JSM, to break in unexpected ways.

Fixing these problems is a necessary first step to doing anything larger. Beyond that, code that uses the message manager is currently required to spread itself across a half dozen different files, and different sections of files, which makes refactoring it to use an actor model even more difficult. That will likely have to be dealt with in a follow-up bug, after this one is fixed.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 1 - Move SpecialPowers wrapping code to separate module. r=nika

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 2 - Always load specialpowersAPI.js as a JSM. r=nika

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 3 - Always load specialpowers.js as a JSM. r=nika

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 4 - Cleanup some cruft in SpecialPowersObserver.jsm. r=nika

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 5 - Let ChromePowers.js handle its own SpecialPowers imports. r=nika

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 6 - Remove some arrant nonsense from ChromePowers.js. r=nika

Comment 7

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 7 - Convert SpecialPowersAPI and sub-classes to ES6 classes. r=nika

Comment 8

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 8 - Convert SpecialPowersObserverAPI and sub-classes to ES6 classes. r=nika

Comment 9

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 9 - Make MozillaLogger.js less insane. r=nika

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 10 - Stop loading MozillaLogger.js from SpecialPowers. r=nika

Comment 11

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 11 - Load SpecialPowersObserverAPI as a JSM.

Comment 12

[Kris Maglione [:kmag]]

Attachment: Bug 1558298: Part 12 - Remove nested OOP support from SpecialPowers and mochitest.

Comment 13

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8b7ed5e149f4d4724c3999b3b0fed9bfd3f8f96
Bug 1558298: Part 1 - Move SpecialPowers wrapping code to separate module. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4419c439e1d92209f237e0d9f1e6c19fa71872
Bug 1558298: Part 2 - Always load specialpowersAPI.js as a JSM. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/c634099abb9dc0196877e626c0df0c168d78876f
Bug 1558298: Part 3 - Always load specialpowers.js as a JSM. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb67ac962bc5bcaaed595f4232b33497f2b38bf7
Bug 1558298: Part 4 - Cleanup some cruft in SpecialPowersObserver.jsm. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/f94500dd11e38ba34310216d958943d6ef07ce96
Bug 1558298: Part 5 - Let ChromePowers.js handle its own SpecialPowers imports. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/162bc1fc273035ca47ad28947f6b339d2101c29b
Bug 1558298: Part 6 - Remove some arrant nonsense from ChromePowers.js. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/d27574cfbb0ed580612d7f468f804aa7819fed21
Bug 1558298: Part 7 - Convert SpecialPowersAPI and sub-classes to ES6 classes. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ccaa25367f28c27c27746593db3bd5cfaed5f57
Bug 1558298: Part 8 - Convert SpecialPowersObserverAPI and sub-classes to ES6 classes. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f6b382f06261055566d91b84866a51a80e474bd
Bug 1558298: Part 9 - Make MozillaLogger.js less insane. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/fddf2808fedf7ca16097af3b5c7c46ed44fc2053
Bug 1558298: Part 10 - Stop loading MozillaLogger.js from SpecialPowers. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a0aab00327b089c82476bea30ea17373e0a1103
Bug 1558298: Part 11 - Load SpecialPowersObserverAPI as a JSM.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2ee912c518913c33e4c63b5a5eddf6e10b0c9f4
Bug 1558298: Part 12 - Remove nested OOP support from SpecialPowers and mochitest.

Comment 14

[Dorel Luca [:dluca]]

Backed out 43 changesets (bug 1561724, bug 1561150, bug 1541557, bug 1561122, bug 1560400, bug 1558298, bug 1561999, bug 1532795, bug 1561061) for multiple failures. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=254379814&repo=mozilla-inbound

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=72630a7c6e6742388107a77afc26c9c191722705

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9bf5e4b0b4f48302d560afb5307d57fbbab7c73

Othere bugs which have been backout in this push can be seen in the backout link.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f859e4de0007
Part 1 - Move SpecialPowers wrapping code to separate module. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1a9d802434
Part 2 - Always load specialpowersAPI.js as a JSM. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/c95e6e599836
Part 3 - Always load specialpowers.js as a JSM. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca88016511bb
Part 4 - Cleanup some cruft in SpecialPowersObserver.jsm. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba24251835fb
Part 5 - Let ChromePowers.js handle its own SpecialPowers imports. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/edd1cc6badf7
Part 6 - Remove some arrant nonsense from ChromePowers.js. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e91fc9541c2
Part 7 - Convert SpecialPowersAPI and sub-classes to ES6 classes. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ccecdba1c34
Part 8 - Convert SpecialPowersObserverAPI and sub-classes to ES6 classes. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/45a9599d9641
Part 9 - Make MozillaLogger.js less insane. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef4ec8f0f886
Part 10 - Stop loading MozillaLogger.js from SpecialPowers. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/d12525990565
Part 11 - Load SpecialPowersObserverAPI as a JSM.
https://hg.mozilla.org/integration/mozilla-inbound/rev/51969e1c9c44
Part 12 - Remove nested OOP support from SpecialPowers and mochitest.

Comment 16

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f859e4de0007
https://hg.mozilla.org/mozilla-central/rev/9b1a9d802434
https://hg.mozilla.org/mozilla-central/rev/c95e6e599836
https://hg.mozilla.org/mozilla-central/rev/ca88016511bb
https://hg.mozilla.org/mozilla-central/rev/ba24251835fb
https://hg.mozilla.org/mozilla-central/rev/edd1cc6badf7
https://hg.mozilla.org/mozilla-central/rev/0e91fc9541c2
https://hg.mozilla.org/mozilla-central/rev/4ccecdba1c34
https://hg.mozilla.org/mozilla-central/rev/45a9599d9641
https://hg.mozilla.org/mozilla-central/rev/ef4ec8f0f886
https://hg.mozilla.org/mozilla-central/rev/d12525990565
https://hg.mozilla.org/mozilla-central/rev/51969e1c9c44

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out 34 changesets (bug 1561150, bug 1541557, bug 1561724, bug 1561999, bug 1558298, bug 1561061, bug 1532795, bug 1560400, bug 1561122) for beta simulation failures (bug 1563905, bug 1564001):
https://hg.mozilla.org/mozilla-central/rev/7e6657f88b7694ecd841088963ff71d767e4ec22

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Relanded (backout got backed out):
https://hg.mozilla.org/mozilla-central/rev/e596664275d5e3e2fdcb7fa8d1447289f99269c3