1560400 - Support remote frames in Window indexed getters and length

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1560400: Part 1 - Support remote frames in Window indexed getters. r=nika

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1560400: Part 2 - Support unwrapping cross-compartment wrappers around remote window proxies. r=mccr8

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1560400: Part 3 - Update DocShell frame navigation tests to support remote frames. r=nika

The tests still fail under Fission, because the mechanisms they use to
navigate the frames don't work, but at least the checks for whether the
navigation succeeded now do. That means the tests should start passing when
the necessary APIs become Fission-compatible.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84633034590f2d1a4c336f9653e6c542f3a09039
Bug 1560400: Part 1 - Support remote frames in Window indexed getters. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf0f0e95c61c2a57d176699f05e71e967a13d3e8
Bug 1560400: Part 3 - Update DocShell frame navigation tests to support remote frames. r=nika

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa2bee0b18c3a1ee1416d0fbf625e0ccdb74bf4e
Bug 1560400: Follow-up: Fix crashtest bustage. r=bustage

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/757d285aafdd9df1d939edb8265948277b6bfe79
Bug 1560400: Follow-up: Really fix crashtest bustage. r=bustage

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95da39224eab
Part 1 - Support remote frames in Window indexed getters. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0bac27bad8a
Part 3 - Update DocShell frame navigation tests to support remote frames. r=nika

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/95da39224eab
https://hg.mozilla.org/mozilla-central/rev/f0bac27bad8a

Comment 10

[Jorg K (CEST = GMT+2)]

Attachment: 1560400-follow-up.patch

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/ac50a7bd09b0
Follow-up: add include of WindowProxyHolder.h to XrayWrapper.cpp. r=kmag a=Aryx

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out 34 changesets (bug 1561150, bug 1541557, bug 1561724, bug 1561999, bug 1558298, bug 1561061, bug 1532795, bug 1560400, bug 1561122) for beta simulation failures (bug 1563905, bug 1564001):
https://hg.mozilla.org/mozilla-central/rev/7e6657f88b7694ecd841088963ff71d767e4ec22

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Relanded (backout got backed out):
https://hg.mozilla.org/mozilla-central/rev/e596664275d5e3e2fdcb7fa8d1447289f99269c3