Closed Bug 1560400 Opened 4 years ago Closed 4 years ago

Support remote frames in Window indexed getters and length

Categories

(Core :: DOM: Core & HTML, task, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Bug 1560400: Part 1 - Support remote frames in Window indexed getters. r=nika
47 bytes, text/x-phabricator-request
Details | Review
Bug 1560400: Part 3 - Update DocShell frame navigation tests to support remote frames. r=nika
47 bytes, text/x-phabricator-request
Details | Review
1560400-follow-up.patch
861 bytes, patch
kmag
: review+
Details | Diff | Splinter Review
No description provided.

The tests still fail under Fission, because the mechanisms they use to
navigate the frames don't work, but at least the checks for whether the
navigation succeeded now do. That means the tests should start passing when
the necessary APIs become Fission-compatible.

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Type: defect → enhancement
Type: enhancement → defect
Fission Milestone: --- → M4
Priority: -- → P2
Blocks: fission-mochitests
No longer blocks: fission
Type: defect → task
https://hg.mozilla.org/integration/mozilla-inbound/rev/84633034590f2d1a4c336f9653e6c542f3a09039
Bug 1560400: Part 1 - Support remote frames in Window indexed getters. r=nika

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf0f0e95c61c2a57d176699f05e71e967a13d3e8
Bug 1560400: Part 3 - Update DocShell frame navigation tests to support remote frames. r=nika
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95da39224eab
Part 1 - Support remote frames in Window indexed getters. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0bac27bad8a
Part 3 - Update DocShell frame navigation tests to support remote frames. r=nika

https://hg.mozilla.org/mozilla-central/rev/95da39224eab
https://hg.mozilla.org/mozilla-central/rev/f0bac27bad8a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Attachment #9076091 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/mozilla-central/rev/ac50a7bd09b0
Follow-up: add include of WindowProxyHolder.h to XrayWrapper.cpp. r=kmag a=Aryx

Backed out 34 changesets (bug 1561150, bug 1541557, bug 1561724, bug 1561999, bug 1558298, bug 1561061, bug 1532795, bug 1560400, bug 1561122) for beta simulation failures (bug 1563905, bug 1564001):
https://hg.mozilla.org/mozilla-central/rev/7e6657f88b7694ecd841088963ff71d767e4ec22

Status: RESOLVED → REOPENED
status-firefox69: fixed → ---
Flags: needinfo?(kmaglione+bmo)
Resolution: FIXED → ---
Target Milestone: mozilla69 → ---

Relanded (backout got backed out):
https://hg.mozilla.org/mozilla-central/rev/e596664275d5e3e2fdcb7fa8d1447289f99269c3

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox69: --- → fixed
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Attachment #9073088 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.