Closed Bug 1559479 Opened 5 months ago Closed 4 months ago

mach lint complains about newtab node_modules

Categories

(Firefox :: Messaging System, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

Attachments

(1 file)

I was working on bug 1558917 directly from m-c and tried to ./mach lint browser/components/newtab but it failed for various files under node_modules:

…
browser/components/newtab/node_modules/node-sass/node_modules/nan/nan.h
browser/components/newtab/node_modules/railroad-diagrams/railroad_diagrams.py
✖ 9142 problems (9142 errors, 0 warnings)

Pretty sure there were no js files as it should already be ignored by m-c's .eslintignore

Probably need to update the ignore of various other linters, e.g., .flake8 .clang-format-ignore

Iteration: --- → 69.4 - Jun 24 - Jul 7
Priority: -- → P2
Component: Activity Streams: Newtab → Messaging System
Iteration: 69.4 - Jun 24 - Jul 7 → 70.1 - Jul 8 - 21
Iteration: 70.1 - Jul 8 - 21 → ---
Priority: P2 → P3
Assignee: nobody → edilee
Type: defect → task
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d08d899e5431
mach lint complains about newtab node_modules r=dmose
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.