1559641 - Chat status selector broken in TB 68 and trunk

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: bad-chat-status.png

See picture. Looks like some de-XBL fallout.

Once to switch to offline, you can't switch to online again :-(

Also on the console:

TypeError: elt.select is not a functionimStatusSelector.js:109:11
statusMessageClick chrome://messenger/content/chat/imStatusSelector.js:109
onclick chrome://messenger/content/messenger.xul:1

Comment 1

[Khushil Mistry [:khushil324]]

This is the same issue as Bug 1523419. elt is this element: https://searchfox.org/comm-central/source/mail/components/im/content/chat-conversation-info.js#66
Previously, it has a method of select. But now it is not working. In Bug 1523419, it is showing an error at this line: https://searchfox.org/comm-central/source/mail/components/im/content/chat-conversation-info.js#165
Does anyone have any idea method "select"? I tried to look into old codes but I didn't find any select method in description, textbox or any related XBL binding. Is there any way to explore the TB 60 code? We can find something there that from where this select was coming previously and what was it doing exactly.

Comment 2

[Jorg K (CEST = GMT+2)]

Can you please always paste permalinks, the links you posted will be stale in no time flat.

You can find Mozilla/TB 60 code here:
https://searchfox.org/mozilla-esr60/source
https://dxr.mozilla.org/mozilla-esr60/source/
https://dxr.mozilla.org/comm-esr60/source/

Comment 3

[Jorg K (CEST = GMT+2)]

So can we have a fix now, please.

Comment 4

[Khushil Mistry [:khushil324]]

(In reply to Jorg K (GMT+2) from comment #3)

So can we have a fix now, please.

Yes, I am working on it. There is also the same type of behavior in imAccounts.xul : https://searchfox.org/comm-central/source/mail/components/im/content/imAccounts.xul#127-133
So, I am taking care of all three things through this bug. There is some styling related issue I am facing. Hopefully, we will be able to land the patch during the weekend.

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1559641_Chat-Status-fixed.patch

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9073365 [details] [diff] [review]
Bug-1559641_Chat-Status-fixed.patch

Thanks, works for me although I'm never quite sure what I should/can type into the box.

Thanks for renaming the`elt` variable while you were there.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9073365 [details] [diff] [review]
Bug-1559641_Chat-Status-fixed.patch

Review of attachment 9073365 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ad11431613a
fixed chat status selector. r=mkmelin

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/161f84d2efe386f6531c86b9f5375ae6d17d305b

Comment 10

[Jorg K (CEST = GMT+2)]

(In reply to Jorg K (GMT+2) from comment #6)

Thanks, works for me although I'm never quite sure what I should/can type
into the box.

OK, you can type into the status box again and switch from Available to Unavailable. However, for Available, only Available is shown, not what I typed into the box. That only shows for Unavailable. Is that as it's supposed to work? Well, that's how it works in TB 60.

Comment 11

[Patrick Cloke [:clokep]]

(In reply to Jorg K (GMT+2) from comment #10)

(In reply to Jorg K (GMT+2) from comment #6)

Thanks, works for me although I'm never quite sure what I should/can type
into the box.

OK, you can type into the status box again and switch from Available to Unavailable. However, for Available, only Available is shown, not what I typed into the box. That only shows for Unavailable. Is that as it's supposed to work? Well, that's how it works in TB 60.

I believe you're always supposed to be able to type in the box. Some protocols allow you to set a "status message" even when available.