1559644 - --enable-warnings-as-errors fails due to -D ellipsis-inclusive-range-patterns with Rust 1.37

Status: RESOLVED DUPLICATE of bug 1564647

(Core :: WebRTC: Signaling, defect, P3)

Description

[Jan Beich]

Probably regressed by https://github.com/rust-lang/rust/pull/61342

$ rustc -vV
rustc 1.37.0-nightly
binary: rustc
commit-hash: 991c719a1d0f95c37ed7ea56bdb38bcc2a6246b9
commit-date: 2019-06-08
host: x86_64-unknown-freebsd
release: 1.37.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig
$ ./mach build
[...]
error: `...` range patterns are deprecated
    --> media/webrtc/signaling/src/sdp/rsdparsa/src/attribute_type.rs:1820:30
     |
1820 |                         x @ 0...0x00ff_ffff => x,
     |                              ^^^ help: use `..=` for an inclusive range
     |
     = note: `-D ellipsis-inclusive-range-patterns` implied by `-D warnings`
error: `...` range patterns are deprecated
    --> media/webrtc/signaling/src/sdp/rsdparsa/src/attribute_type.rs:1829:30
     |
1829 |                         x @ 0...2 => x,
     |                              ^^^ help: use `..=` for an inclusive range
error: `...` range patterns are deprecated
    --> media/webrtc/signaling/src/sdp/rsdparsa/src/attribute_type.rs:1867:22
     |
1867 |                 x @ 0...128 => parameters.encodings.push(x),
     |                      ^^^ help: use `..=` for an inclusive range
error: `...` range patterns are deprecated
    --> media/webrtc/signaling/src/sdp/rsdparsa/src/attribute_type.rs:1884:22
     |
1884 |                     0...100 => Some(x),
     |                      ^^^ help: use `..=` for an inclusive range
error: `...` range patterns are deprecated
   --> media/webrtc/signaling/src/sdp/rsdparsa/src/media_type.rs:374:24
    |
374 |                     96 ... 127 => (),  // dynamic range
    |                        ^^^ help: use `..=` for an inclusive range
error: aborting due to 5 previous errors
error: Could not compile `webrtc-sdp`.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1559644 - fix inclusive range and mut warnings in Rust SDP parser - r?dminor

fixes new inclusive range warnings, fixes mut warnings

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7023dc16e0a02e8cf790cb0be4476b5aac772106

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?
For more information, please visit auto_nag documentation.