Fix python3 source compatibility
Categories
(Firefox Build System :: General, task)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: marco, Assigned: catlee)
References
(Blocks 1 open bug)
Details
Attachments
(43 files, 15 obsolete files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
| Reporter | ||
Comment 1•6 years ago
|
||
| Assignee | ||
Updated•6 years ago
|
Comment 2•6 years ago
|
||
| Reporter | ||
Comment 3•6 years ago
|
||
| Reporter | ||
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Comment 9•6 years ago
|
||
Depends on D35243
| Assignee | ||
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
| Assignee | ||
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
Comment 14•6 years ago
|
||
Comment 15•6 years ago
|
||
Comment 16•6 years ago
|
||
| Assignee | ||
Comment 17•6 years ago
|
||
| Assignee | ||
Comment 18•6 years ago
|
||
Comment 19•6 years ago
|
||
| Assignee | ||
Comment 20•6 years ago
|
||
Updated•6 years ago
|
| Assignee | ||
Comment 21•6 years ago
|
||
Depends on D35337
Updated•6 years ago
|
Updated•6 years ago
|
Comment 22•6 years ago
|
||
Comment 23•6 years ago
|
||
Comment 24•6 years ago
|
||
Updated•6 years ago
|
Comment 25•6 years ago
|
||
Comment 26•6 years ago
|
||
Backed out 3 changesets (bug 1559975) for Build bustage. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253174786&repo=autoland&lineNumber=1838
Push with failure:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bdb15150dc59c3c37682cdfa6e28e87d528e257c
Backout:
https://hg.mozilla.org/integration/autoland/rev/64e93c6ae4e7d01b3454df3be1df27128f87330e
Comment 27•6 years ago
|
||
:dluca - I only authored one of the patches; will ni the other two and we'll coordinate.
Comment 28•6 years ago
|
||
This was mainly run to get the 'from future' statements on all on the same
line. But might as well let the other imports get sorted too while we're at it.
I manually removed any changes that looked like they might fail due to import
ordering.
Comment 29•6 years ago
|
||
My mistake, thought the patch was trivial and looked right. I'll be sure to test better next time.
Moving forward, I'd like to ask patch authors to avoid landing their patches after they get r+ed. I'll try to batch 3-5 of them at a time as they get reviewed in the phabricator stack (taking care to test them a bit better first). If certain patches prove to be more difficult to land, we can manually edit the revision ordering in phabricator to get them to the end of the queue.
Updated•6 years ago
|
Comment 30•6 years ago
|
||
Comment 31•6 years ago
|
||
Comment 32•6 years ago
|
||
Depends on D36090
Comment 33•6 years ago
|
||
Depends on D36091
Comment 34•6 years ago
|
||
Depends on D36092
Comment 35•6 years ago
|
||
Depends on D36093
Comment 36•6 years ago
|
||
Depends on D36094
Comment 37•6 years ago
|
||
Depends on D36095
Comment 38•6 years ago
|
||
Depends on D36096
Comment 39•6 years ago
|
||
Backed out 5 changesets (Bug 1559982, Bug 1559975) for cpp unit test failures due to unsupported operand type.
Backout link: https://hg.mozilla.org/integration/autoland/rev/18f3d786c2897b9b58987bd5eeac3c05d559bd2c
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=253601399&repo=autoland&lineNumber=1357
[task 2019-06-26T22:31:14.006Z] 22:31:14 INFO - adb Native pidof support: True
[task 2019-06-26T22:31:15.544Z] 22:31:15 INFO - unsupported operand type(s) for >>: 'builtin_function_or_method' and 'file'
[task 2019-06-26T22:31:15.554Z] 22:31:15 ERROR - Return code: 1
[task 2019-06-26T22:31:15.554Z] 22:31:15 ERROR - No tests run or test summary not found
[task 2019-06-26T22:31:15.556Z] 22:31:15 INFO - TinderboxPrint: cppunittest<br/><em class="testfail">T-FAIL</em>
[task 2019-06-26T22:31:15.556Z] 22:31:15 INFO - ##### cppunittest log ends
[task 2019-06-26T22:31:15.556Z] 22:31:15 WARNING - # TBPL WARNING #
[task 2019-06-26T22:31:15.556Z] 22:31:15 WARNING - setting return code to 1
Comment 40•6 years ago
|
||
Comment 41•6 years ago
|
||
I re-landed without the offending patch. We'll fix/re-land that one in due time.
Comment 42•6 years ago
|
||
| bugherder | ||
Comment 43•6 years ago
|
||
Comment 44•6 years ago
|
||
Comment 45•6 years ago
|
||
| bugherder | ||
Comment 46•6 years ago
|
||
Comment 47•6 years ago
|
||
Updated•6 years ago
|
Comment 48•6 years ago
|
||
Updated•6 years ago
|
Comment 49•6 years ago
|
||
| bugherder | ||
Comment 50•6 years ago
|
||
Updated•6 years ago
|
Comment 51•6 years ago
|
||
Comment 52•6 years ago
|
||
Comment 53•6 years ago
|
||
Comment 54•6 years ago
|
||
Comment 55•6 years ago
|
||
Comment 56•6 years ago
|
||
Comment 57•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d0dda220d0d2
https://hg.mozilla.org/mozilla-central/rev/0a1d70a3f84d
https://hg.mozilla.org/mozilla-central/rev/f4ccc9904965
https://hg.mozilla.org/mozilla-central/rev/68ade9168329
https://hg.mozilla.org/mozilla-central/rev/64da8793fde3
https://hg.mozilla.org/mozilla-central/rev/5712b6093001
https://hg.mozilla.org/mozilla-central/rev/144f35689cd2
https://hg.mozilla.org/mozilla-central/rev/98dd5736b303
https://hg.mozilla.org/mozilla-central/rev/fb193ef6ed3f
Comment 58•6 years ago
|
||
Comment 59•6 years ago
|
||
Comment 60•6 years ago
|
||
| bugherder | ||
Comment 61•6 years ago
|
||
| Assignee | ||
Comment 62•6 years ago
|
||
| Assignee | ||
Comment 63•6 years ago
|
||
Comment 64•6 years ago
|
||
Comment 65•6 years ago
|
||
Comment 66•6 years ago
|
||
Comment 67•6 years ago
|
||
Comment 68•6 years ago
|
||
Comment 69•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 70•6 years ago
|
||
Comment 71•6 years ago
|
||
Comment 72•6 years ago
|
||
Phabricator Differential: https://phabricator.services.mozilla.com/D36388
Updated•6 years ago
|
Updated•6 years ago
|
Comment 73•6 years ago
|
||
Comment 74•6 years ago
|
||
Comment 75•6 years ago
|
||
Updated•6 years ago
|
Comment 76•6 years ago
|
||
Comment 77•6 years ago
|
||
Backed out 3 changesets (bug 1559975) for linting failure at WebIDL.py on a CLOSED TREE.
Backout link: https://hg.mozilla.org/integration/autoland/rev/44e8fbdf5cbd72ed09fc4589d7119c29f051ee72
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257395584&repo=autoland&lineNumber=277
Log snippet:
[task 2019-07-19T14:24:29.805Z] building 'psutil._psutil_linux' extension
[task 2019-07-19T14:24:29.805Z] creating build
[task 2019-07-19T14:24:29.805Z] creating build/temp.linux-x86_64-2.7
[task 2019-07-19T14:24:29.805Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2019-07-19T14:24:29.805Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-07-19T14:24:29.805Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-07-19T14:24:29.805Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2019-07-19T14:24:29.805Z] creating build/lib.linux-x86_64-2.7
[task 2019-07-19T14:24:29.805Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2019-07-19T14:24:29.805Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2019-07-19T14:24:29.805Z] building 'psutil._psutil_posix' extension
[task 2019-07-19T14:24:29.805Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-07-19T14:24:29.805Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-07-19T14:24:29.805Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-07-19T14:24:29.805Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-07-19T14:24:29.805Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-07-19T14:24:29.805Z]
[task 2019-07-19T14:24:29.805Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-07-19T14:24:43.424Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/dom/bindings/parser/WebIDL.py:7305:23 | invalid syntax (is-parseable)
[task 2019-07-19T14:24:43.424Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/dom/bindings/parser/runtests.py:25:36 | Missing parentheses in call to 'print' (is-parseable)
[taskcluster 2019-07-19 14:24:44.025Z] === Task Finished ===
[taskcluster 2019-07-19 14:24:44.819Z] Unsuccessful task run with exit code: 1 completed in 287.032 seconds
Comment 78•6 years ago
|
||
Comment 79•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/86db58cfefc5
https://hg.mozilla.org/mozilla-central/rev/9ee6d23124d8
https://hg.mozilla.org/mozilla-central/rev/40fa59e314fe
https://hg.mozilla.org/mozilla-central/rev/e2924a3e899d
https://hg.mozilla.org/mozilla-central/rev/5cd6191dbe16
https://hg.mozilla.org/mozilla-central/rev/b36f917162a5
https://hg.mozilla.org/mozilla-central/rev/288cfb1ca4ce
https://hg.mozilla.org/mozilla-central/rev/18c1e6d07656
https://hg.mozilla.org/mozilla-central/rev/d9bce64ad7ac
https://hg.mozilla.org/mozilla-central/rev/6a5f9886c13f
https://hg.mozilla.org/mozilla-central/rev/9bcc17e87089
https://hg.mozilla.org/mozilla-central/rev/fe7bfad1dac4
Comment 80•6 years ago
|
||
Clearing ni
Comment 82•6 years ago
|
||
| Assignee | ||
Comment 83•6 years ago
|
||
| Assignee | ||
Comment 84•6 years ago
|
||
| Assignee | ||
Comment 85•6 years ago
|
||
Depends on D40490
Comment 86•6 years ago
|
||
Comment 87•6 years ago
|
||
| bugherder | ||
Updated•6 years ago
|
Comment 88•6 years ago
|
||
Comment 90•6 years ago
|
||
Backed out changeset acf99165d2fd (Bug 1559975) for wptlint failure
Backout link: https://hg.mozilla.org/integration/autoland/rev/6fe9875279652b5818d36fc0025af1e84f5e6ae1
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264148654&repo=autoland&lineNumber=68
[task 2019-08-29T23:26:48.594Z] building 'psutil._psutil_posix' extension
[task 2019-08-29T23:26:48.594Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2019-08-29T23:26:48.594Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2019-08-29T23:26:48.594Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2019-08-29T23:26:48.594Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-08-29T23:26:48.594Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-08-29T23:26:48.594Z]
[task 2019-08-29T23:26:48.594Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-08-29T23:26:48.694Z] No specific files specified, running the full wpt lint (this is slow)
[task 2019-08-29T23:31:56.439Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/testing/web-platform/tests/css/css-fonts/support/fonts/makegsubfonts.py:128 | Unable to parse file (PARSE-FAILED)
[task 2019-08-29T23:31:56.439Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/tools/lint/wpt.yml:0 | Lint process exited with return code 1 (wpt)
[taskcluster 2019-08-29 23:31:56.753Z] === Task Finished ===
[taskcluster 2019-08-29 23:31:57.525Z] Unsuccessful task run with exit code: 1 completed in 331.703 seconds
Comment 92•6 years ago
|
||
Comment 93•6 years ago
|
||
| bugherder | ||
Comment 94•6 years ago
|
||
Pushed a fixed patch and it landed successfully. Removing ni
Updated•6 years ago
|
Comment 95•6 years ago
|
||
| bugherder uplift | ||
Comment 96•6 years ago
|
||
Comment 97•6 years ago
|
||
| bugherder | ||
Updated•6 years ago
|
Comment 98•6 years ago
|
||
Comment 99•6 years ago
|
||
Comment 100•6 years ago
|
||
| bugherder | ||
Comment 102•6 years ago
|
||
Comment 103•6 years ago
|
||
| bugherder | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 105•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 106•6 years ago
|
||
| bugherder | ||
WPT import of layout/reftests/w3c-css/submitted/ changes in https://github.com/web-platform-tests/wpt/pull/20925
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 108•5 years ago
|
||
One patch that hasn't landed but it's not a big deal. I think we can call this fixed.
Updated•5 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Description
•