1559991 - Show the dismissed doorhanger upon filling a generated password

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[Matthew N. [:MattN]]

To:

• ensure that the user can always add their username after saving a generated password
• ensure that the user can manually save the generated password in cases where we don't auto-save it

We need to show the capture doorhanger (including a potential username) to allow the user to save/update the username and/or password.

Comment 1

[Matthew N. [:MattN]]

Implementation order we discussed:
Part 1: Show doorhanger without username
Part 2: Include the username from content

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1559991 - Part 1: Share the doFillGeneratedPasswordContextMenuItem test helper. r?MattN

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1559991 - Part 2: Create dismissed prompt when filling with a generated password login. r?MattN

Depends on D36859

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1559991 - Part 3: Include username in save-password prompt when filling with generated password. r?MattN

Depends on D36860

Comment 5

[Sam Foster [:sfoster] (he/him)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b8204f7edb39352b6c155de227a811b47b74b39

Comment 6

[Matthew N. [:MattN]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #5)

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b8204f7edb39352b6c155de227a811b47b74b39

I was going to land this for you but it looks like there are test failures.

Comment 7

[Sam Foster [:sfoster] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc5985d9a4e755da0668f58950a9cd8c4f671854

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab17d02d2093
Part 1: Share the doFillGeneratedPasswordContextMenuItem test helper. r=MattN
https://hg.mozilla.org/integration/autoland/rev/540908f19ed1
Part 2: Create dismissed prompt when filling with a generated password login. r=MattN
https://hg.mozilla.org/integration/autoland/rev/49509781bc6b
Part 3: Include username in save-password prompt when filling with generated password. r=MattN

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ab17d02d2093
https://hg.mozilla.org/mozilla-central/rev/540908f19ed1
https://hg.mozilla.org/mozilla-central/rev/49509781bc6b

Comment 10

[Timea Cernea [:tbabos][inactive]]

Hey Sam,

After filling in the password field with the generator and without any username the password will be auto-saved.
Tapping the blue key icon will display the doorhanger with pre-filled password and with a placeholder for the user name (as expected).

However, the doorhanger string will be: "Would you like to update this password?"
Is this correct? Shouldn't it be to update the login info for the given site?

Screenshot attached for reference.

Comment 11

[Timea Cernea [:tbabos][inactive]]

Attachment: Actual result

Comment 12

[Sam Foster [:sfoster] (he/him)]

(In reply to Timea Babos from comment #10)

After filling in the password field with the generator and without any username the password will be auto-saved.
Tapping the blue key icon will display the doorhanger with pre-filled password and with a placeholder for the user name (as expected).

However, the doorhanger string will be: "Would you like to update this password?"
Is this correct? Shouldn't it be to update the login info for the given site?

It is using the correct string, but I agree that in this context we are really offering the opportunity where arguably "Would you like to update this login" might make more sense than "Would you like to update this password?" That would need to be filed as a separate bug though.

Comment 13

[Timea Cernea [:tbabos][inactive]]

Thank you Sam!

Verified - Fixed on latest Nightly 70.0a1 (2019-07-29) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04.
The dismissed doorhanger can be accessed via the key icon after filling in a generated password:

• "No username" placeholder can be seen for the empty username field
• Filling the username on the form and submitting will trigger once more the doorhanger to update the login information
• The username and password can be edited in both the above-mentioned doorhangers

Submitted Bug 1569917 for the string discussed in Comment 12.