Closed Bug 1560751 Opened 5 months ago Closed 5 months ago

Contacts sidebar of compose window forgets last selected AB and repeatedly defaults to "All Address Books"

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set

Tracking

(thunderbird68+ fixed, thunderbird69 fixed)

RESOLVED FIXED
Thunderbird 69.0
Tracking Status
thunderbird68 + fixed
thunderbird69 --- fixed

People

(Reporter: yourz2day-bugz, Assigned: aleca)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Opened composition window with contacts sidebar displayed.

Actual results:

Contacts sidebar opens showing "All Address Books." Changed this to "Personal Address Book" (in pop-up at top of list). Next time a composition window is opened, contacts sidebar again shows "All Address Books" (evidently by default).

Expected results:

Contacts sidebar should default to last selected address book, and this setting should also be retained upon quitting and re-launching TB.

This problem existed in the past, and was fixed (e.g., see Bug 1142705) but it has returned with version 68.0b1 (Mac OS 10.10.5).

Confirmed, Alice, could you please find the regression for us.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(alice0775)

As an alternative to defaulting to the "last selected" list, the choice of contact list (including "last used list") could conceivably be set by a pop-up in the "Composition" preference pane, in much the same fashion as the setting for "Default startup directory in address book window."

I'll leave it to others to determine which solution is more practical and desirable for more users. :-)

Thank you so much, Alice!

We might as well restore the previous behaviour. Alex, can you please take a look.

Assignee: nobody → alessandro
Status: NEW → ASSIGNED
Flags: needinfo?(alessandro)
Summary: Contacts sidebar repeatedly defaults to "All Address Books" → Contacts sidebar of compose window forgets last selected AB and repeatedly defaults to "All Address Books"

On it, thanks for finding the regression.

Flags: needinfo?(alessandro)

Patch ready to be reviewed.

Attachment #9073635 - Flags: review?(mkmelin+mozilla)
Regressed by: 1542711
Comment on attachment 9073635 [details] [diff] [review]
1560751-addressbook-compose.patch

Review of attachment 9073635 [details] [diff] [review]:
-----------------------------------------------------------------

The aSelectValue param seems ununsed, so please remove it.

::: mail/components/addrbook/content/menulist-addrbooks.js
@@ +178,1 @@
>        }

This could just be

      this.selectedIndex = this._directories.findIndex((d) => {
        return d && d.URI == this_value;
      });
Attachment #9073635 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9073635 - Attachment is obsolete: true
Attachment #9073871 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4aed62fba5e7
fix AB selection forgetting last selected AB in contacts sidebar. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0

Thank you for the quick follow-up!

Bravo! I'll be looking for the fix (in v 69beta?).

Will be shipping in TB 68 beta 3.

Cool! :-)

You need to log in before you can comment on or make changes to this bug.