1562316 - Reports of emojis not visible while typing text in textbox

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Emily Kager [:ekager]]

See: https://github.com/mozilla-mobile/fenix/issues/3643

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Working for me here. Pixel 2 running Q.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Seems similar to bug 1502286 which was fixed months ago.

Comment 3

[Chris Peterson [:cpeterson]]

I can't reproduce this bug in Fenix 1.0.1926 (GV 68.0-20190612114833) on my Moto G5 Plus running Android 8.1.0. I'll ask the original bug reporter on GitHub.

Comment 4

[Chris Peterson [:cpeterson]]

The bug reporter says he can still reproduce this emoji bug using the Google board keyboard on his OnePlus 3T running Android 9.0 Pie:

https://github.com/mozilla-mobile/fenix/issues/3643#issuecomment-508314004

Comment 5

[Chris Peterson [:cpeterson]]

I'm moving this bug to the WebRender component because the bug reporter says the problem is caused by enabling WebRender:

https://github.com/mozilla-mobile/fenix/issues/3643#issuecomment-509966651

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Jamie, can you reproduce this?

Comment 7

[Jamie Nicol [:jnicol] out of office until 6th Jan]

Yes, I can reproduce. Will have a look.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Possibly related: https://searchfox.org/mozilla-central/rev/f372470e10c8cb0691681603a1d6324dee5b3b8a/layout/reftests/text/reftest.list#196

Comment 9

[Jeff Muizelaar [:jrmuizel]]

Lee might also have a guess at what might be happening here.

Comment 10

[Jamie Nicol [:jnicol] out of office until 6th Jan]

The reason emojis are visible in tweets on the timeline but not in the text box is that in the timeline they are shown as <img>s, but they are just text in the text box. Same goes for github.

So it seems like emojis simply aren't being rendered ever with webrender on android, nothing text box specific. Confirmed by a simple test page (and comment 8 seems to confirm this too.)

I will follow the code and see if I can find out where it's going wrong, unless Lee can instantly guess?

Comment 11

[Jamie Nicol [:jnicol] out of office until 6th Jan]

We aren't setting the FontInstanceFlags::EMBEDDED_BITMAPS flag in ScaledFontFreeType::GetWRFontInstanceOptions(), so in FontContext::load_glyph() we are forced in to taking the non-bitmap / scalable code path, which fails on android because emojis are bitmap only.

Setting the flag there causes us to take the bitmap / fixed-size path, which succeeds, and emojis are drawn correctly 🙌🙌🙌🎉🎉🎉

Comment 12

[Jamie Nicol [:jnicol] out of office until 6th Jan]

Attachment: Bug 1562316 - Fix emoji rendering on android webrender. r?lsalzman

ScaledFontFreeType::GetWRFontInstanceOptions() was neglecting to set
the FontInstanceFlags::EMBEDDED_BITMAPS flag. This was causing us to
always take the non-bitmap path when rasterizing the glyph, which
fails on android because emoji fonts are bitmap only. Setting this
flag causes glyphs to be rendered correctly on android webrender.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bac526dab75d
Fix emoji rendering on android webrender. r=lsalzman

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bac526dab75d

Comment 15

[Intermittent Failures Robot]

3 failures in 4439 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 2
• autoland: 1

Platform breakdown:

• android-hw-p2-8-0-arm7-api-16-qr: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1562316&startday=2019-07-29&endday=2019-08-04&tree=all