Use HTML input instead of XUL textbox in abCard.inc.xul
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: aleca, Assigned: aleca)
References
Details
Attachments
(1 file, 7 obsolete files)
48.42 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
New contact dialog ready for review.
The Photo tab doesn't really work, but it's not related to the input conversion.
I reported it on bug 1581253.
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
The department field shows up for me, how does it look for you?
Regarding the Address double line, I'd suggest to leave it as it's pretty common to have 2 address lines for extra info, like apartment #, buzzer, etc.
I noticed that the label for the second line doesn't actually have any text.
Should we add it for accessibility?
Comment 4•6 years ago
|
||
I notice there are other things off too.
Re "keep" it on one line, i was referring to the actual code. (That you now put each attribute on its own line.)
Assignee | ||
Comment 5•6 years ago
|
||
Yeah, I noticed now the Stat/Province line being busted.
I'm reworking the patch, and applying the aria-labelledby
attribute as well.
Assignee | ||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
This is so weird.
What about this?
Comment 9•6 years ago
|
||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
I think I figured it out.
For some reason your fields have a min-width
that doesn't allow them to properly "flex" into the limits of their container.
It doesn't happen on mine, it might be a HiDPI thing.
Working on a fix.
Assignee | ||
Comment 12•6 years ago
|
||
This should do it.
Comment 13•6 years ago
|
||
Assignee | ||
Comment 14•6 years ago
|
||
Patch updated and try-run pushed: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b50186e4b9b764edfeb4e41079bb1980897a579c
This will remove 48 textbox
elements, yay!
Comment 15•6 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/06921c904e77
Use HTML input instead of XUL textbox in abCard.inc.xul. r=mkmelin
Updated•6 years ago
|
Description
•