Closed Bug 1563451 Opened 6 years ago Closed 6 years ago

68 regression: javascript bookmarklets can no longer be invoked by their keyword

Categories

(Firefox :: Address Bar, defect)

68 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1552141

People

(Reporter: bughit.github, Unassigned)

Details

  • win7
  • firefox 68.0.0 rc1
  • new profile
  • create a javascript bookmarklet with a keyword javascript:void alert('%s');
  • invocation via a click works
  • but via the keyword does not (performs a google search)

@bzbarsky I found Bug 1478037, is it related to this?

Please fix this in 68.

Flags: needinfo?(bzbarsky)
Keywords: regression

also broken in 69.0b1

@bzbarsky I found Bug 1478037, is it related to this?

I really doubt it.

Does toggling the "browser.urlbar.quantumbar" to false make things work right for you? As far as I can tell, that's the issue here: the new url bar code is not handling this correctly.

Component: DOM: Core & HTML → Address Bar
Flags: needinfo?(mak77)
Flags: needinfo?(bzbarsky)
Flags: needinfo?(bughit.github)
Product: Core → Firefox
Regressed by: 1548031

And in particular, I have a javascript: bookmarklet that I use for bisection results, and I see it being broken on current nightly but working correctly when I toggle "browser.urlbar.quantumbar" to false...

Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(mak77)
Flags: needinfo?(bughit.github)
No longer regressed by: 1548031
Resolution: --- → DUPLICATE

And it looks like I didn't notice this earlier because I toggled the pref off due to bug 1550025 and then forgot to re-enable it when that was fixed.... :(

Unfortunately, the chances of this being fixed in 68 at this point are pretty slim; rc1 means that only serious stop-ship issues would get fixed, and I doubt this makes the cut.

Type: -- → defect
Keywords: regression
You need to log in before you can comment on or make changes to this bug.