1560183 - Re-Enable RDD Process

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, defect)

Description

[Tom Ritter [:tjr]]

Once Bug 1557844 is uplifted; I can close Bug 1553721 and then use this bug to revert Bug 1553726

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1560183 - Re-enable the RDD Process for MinGW builds r?jya

Bug 1557844 fixed (inadvertently) the failures we were getting with RDD

Comment 2

[Tom Ritter [:tjr]]

Putting this up now since Bug 1557844 is fixed in 69 and -central (70). We can land this in central today and uplift to 68 once Bug 1553721 is uplifted there.

We could in theory uplift this to 69 just to be consistent; but no one will use the 69-based MinGW build so it is not required.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b281af2f2eae
Re-enable the RDD Process for MinGW builds r=jya

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b281af2f2eae

Comment 5

[Tom Ritter [:tjr]]

[Tracking Requested - why for this release]: We disabled the RDD process for MinGW on 68 because it was crashing. We identified the source of the crash and backported the fix in Bug 1557844. Now we can re-enable it.

Comment 6

[Tom Ritter [:tjr]]

Comment on attachment 9078581 [details]
Bug 1560183 - Re-enable the RDD Process for MinGW builds r?jya

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: We disabled the RDD process for MinGW on 68 because it was crashing. We identified the source of the crash and backported the fix in Bug 1557844. Now we can re-enable it.
• User impact if declined: Tor Browser will need to backport the patch and when we start running tests on esr68 we'll be running them in an unsupported configuration.
• Fix Landed on Version: 70.0a1
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects MinGW
• String or UUID changes made by this patch:

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 8

[Tom Ritter [:tjr]]

While 69 is affected; I don't need an uplift there as no one will use a mingw build off 69 and I won't enable tests there.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078581 [details]
Bug 1560183 - Re-enable the RDD Process for MinGW builds r?jya

Re-enables the RDD process for MinGW builds. NPOTB for official Firefox releases. Approved for 68.1esr.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/1b09a11d1ca3