1565254 - Old about:config warning title lacks contrast in dark mode

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Kestrel]

Attachment: Invisible warning title

STR:

1. Use a dark system theme or set ui.systemUsesDarkTheme = 1.
2. Make sure general.warnOnAboutConfig = true.
3. Go to the old about:config page chrome://global/content/config.xul.

The warning title is barely readable.

Comment 1

[Kestrel]

Attachment: Bug 1565254 - Old about:config warning title should inherit text color for dark mode compatibility

Comment 2

[Tim Nguyen :ntim]

This blocks enabling the in-content dark mode since old about:config is still on by default on release/beta.

Comment 3

[Tim Nguyen :ntim]

Thanks for taking this on Kestrel :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3804754bb79
Old about:config warning title should inherit text color for dark mode compatibility r=dao

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f3804754bb79

Comment 7

[Patrick (he/him)]

Managed to reproduce the issue on an affected build 69.0a1 (2019-05-20, build 20190520215528), using the steps to reproduce from the description, on Windows 10x64.

The issue is no longer reproducible on Firefox 72 (build 20191230161130). Tests were performed under Windows 10x64.