1580955 - warning title unreadable in about:config with browser.in-content.dark-mode

Status: RESOLVED DUPLICATE of bug 1565254

(Toolkit :: Preferences, defect)

Description

[sergio]

Attachment: about:config.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

browser.in-content.dark-mode=true

this issue is reproducible under linux or windows

Comment 1

[Virginia (please send need info request to Brindusa Tot)]

Hi Sergio,

We will continue the investigation about this issue on this bug, as previously discussed on https://bugzilla.mozilla.org/show_bug.cgi?id=1579680
I tested this issue using Adwaita-dark theme on Ubuntu 18.04.2 LTS with the following Firefox versions:

• Firefox Nightly 71.0a1 (2019-09-16) (64-bit): UNABLE TO REPRODUCE
• Firefox Beta 70.0b6 (64-bit) : UNABLE TO REPRODUCE
• Release 69.0 (64-bit): unable to reproduce the exact behavior as per your screenshot, but I do see a BUG since the page remains white instead of changing its colors according to the dark theme applied. (I'll attach a screenshot on the next comment)

Since the issue is reproducible on the Release version 69, and not reproducible on Nightly 71, it means that it has been fixed and when the Release version reaches 71 the issue will no longer be reproducible.

Could you please confirm that the issue is fixed on Firefox Nightly on your end?

Regards,

Comment 2

[Virginia (please send need info request to Brindusa Tot)]

Attachment: Ubuntu about:config Release 69

Comment 3

[sergio]

You have not set browser.in-content.dark-mode=true (and may be restarted ff after this) as you should see dark-themed page.

While it looks good on Nightly, I can't confirm it's fixed on Nightly as the page's content differs.

Comment 4

[Virginia (please send need info request to Brindusa Tot)]

You are right, I tested with a fresh profile, set the browser.in-content.dark-mode=true and got your result on Release 69.0 (like Attached image about:config.png), but I'm still unable to reproduce this on Nightly, do you mean that the about:config page has different text?

Release says: "This may void your warranty
Nightly says: "Here be dragons!"

Thanks!

Comment 5

[sergio]

do you mean that the about:config page has different text?

Release says: "This may void your warranty
Nightly says: "Here be dragons!"

Right, this is only the visible different part.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

browser.in-content.dark-mode=true is not an officially supported pref for 69, but will be starting in 70. Can you please test Firefox Beta with browser.in-content.dark-mode=true?

Does the text still appear as black-on-black in Firefox 70 Beta with browser.in-content.dark-mode=true?

Comment 7

[Virginia (please send need info request to Brindusa Tot)]

Hi Jared,

In Beta 70.b7 (64-bit), the copy that appears in about:config is: "This might void your warranty!", the same one as in Release 69.0.1

Note that in Release 69.0.1, "This might void your warranty!" text shows barely visible when using Adwaita-dark theme on Ubuntu 18.04.2 LTS, but on Beta 70.0b7 it appears to be fixed.

The main issue here would be that the Release and Beta text don't match Nightly. I'll be attaching screenshots on my following comment.

Thanks,
Virginia

Comment 8

[Virginia (please send need info request to Brindusa Tot)]

Attachment: Release about config.JPG

Comment 9

[Virginia (please send need info request to Brindusa Tot)]

Attachment: Beta about config.JPG

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Thanks Virginia. The difference in text between Nightly and Beta/Release is expected. Nightly is showing a new about:config that doesn't exist on Beta/Release.

Since the text isn't black-on-black in beta, then this bug can be closed since the preference being used, browser.in-content.dark-mode=true, is not fully supported on Release 69.