Open Bug 156547 Opened 19 years ago Updated 4 months ago

collapsed scrollbars should not trigger reflow

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

Future

People

(Reporter: dbaron, Unassigned)

References

Details

(Keywords: perf, Whiteboard: [patch])

Attachments

(2 files)

Right now collapsed scrollbars trigger reflows, which is wasteful.  See bug
156522 comment 4, and the testcase on bug 156522.
Attached patch patch, v 2.0Splinter Review
This patch actually works without the one from bug 156522.
Whiteboard: [patch]
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P2
Target Milestone: --- → mozilla1.2alpha
Comment on attachment 90678 [details] [diff] [review]
patch, v 2.0

sr=hyatt
Attachment #90678 - Flags: superreview+
Comment on attachment 90678 [details] [diff] [review]
patch, v 2.0

r=bryner
Attachment #90678 - Flags: review+
I checked in the XBL changes, 2002-08-06 06:39 PDT, but I didn't check in the
nsGfxScrollFrame.cpp change because I noticed a problem that it causes when I
maximize a window showing (scrolled a bit from the top) a page that needs a
scrollbar at the small window size but not the large one.
Target Milestone: mozilla1.2alpha → Future
The problem with this patch still remains.
Depends on: 201435
Is this still relevant after roc's recent checkin?
I need to check...
Possibly related to Bug 451816?
Not related to that, no.
QA Contact: chrispetersen → layout
FWIW, I noticed recently while playing with performance tweaks on on Windows Vista/7 and visiting other bugs about reflow being triggered (the one with the test to count the # of reflow triggers).  

If the Windows setting to turn off 'show contents of window while drag' is unchecked, it reduces the reflow to 'one time' if just resizing the browser window then let go.  But, it reflows 'continuously' while resizing the window with the Windows setting enabled.

So currently it appears that Firefox gives users this instantaneous effect that where we see the size/layout of the all browser content in order to adjust to maximum viewing pleasure.
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Assignee: dbaron → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.