1565482 - [META] Centralize all client -> server communication in one place

Status: RESOLVED FIXED

(DevTools :: Console, task, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

At the moment the console doesn't have a clearly defined pattern to handle the communication from the client to the server.

Sometimes we do it in actions, or in middleware/enhancers, sometimes directly from the component, sometimes in webconsole-ui, etc…

This is kinda getting in our way for the Fission project, as we need a clear view of all the client <-> server communications, to take appropriate architecture decisions in order to handle multiple processes/frames.

We should follow what's done in other panel (like netmonitor, debugger, …) and have everything in one place.
This would help us have a better view of all the possible communications.
This should also help us enforce what those communications can be at component level (i.e. a component shouldn't be able to simply grab the client and call any method it wants on it).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Let's have this as a meta so we can have smaller actionable bugs to work on

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some links to the Network monitor panel code base for inspiration:

• Abstract Connector interface used to talk to the back-end
  https://searchfox.org/mozilla-central/rev/15be167a5b436b57fef944b84eef061d24c1af8c/devtools/client/netmonitor/src/connector/index.js#12

• FirefoxConnector implementation. This is for connecting to Firefox backend
  https://searchfox.org/mozilla-central/rev/15be167a5b436b57fef944b84eef061d24c1af8c/devtools/client/netmonitor/src/connector/firefox-connector.js#22

This object represents the single point used to fetch data or receive events from the backend

• Experimental ChromeConnector
  https://searchfox.org/mozilla-central/rev/15be167a5b436b57fef944b84eef061d24c1af8c/devtools/client/netmonitor/src/connector/chrome-connector.js#10

Connecting to Chrome backend over CDP

• Connecting to Firefox backend is done by default as part of the connecting sequence.
  https://searchfox.org/mozilla-central/rev/15be167a5b436b57fef944b84eef061d24c1af8c/devtools/client/netmonitor/src/api.js#94

Honza

Comment 3

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6)

Comment 4

[Chris Peterson [:cpeterson]]

dt-fission-reserve bugs do not need to block Fission Nightly (M6), but these bugs' summaries mention the word "Fission", so let's track them for Fission riding the trains to Beta (M7). We'll revisit these bugs before we ship Fission.

Comment 5

[Neha Kochar [:neha]]

Bulk change of all bugs with whiteboard tag of dt-fission to Fission MVP milestone.

Comment 6

[Chris Peterson [:cpeterson]]

Moving old "dt-fission" bugs to "dt-fission-future" because they don't block Fission MVP.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

This can probably be done using the "commands" pattern we're discussing about in Bug 1691681

Comment 8

[Alexandre Poirot [:ochameau]]

We can probably improve that even more, may be via bug 1568499, but it looks like the bulk of work has been completed here.