1565910 - Phabricator's borders are corrupt again.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

This is a recent-ish regression. Screenshot incoming. I also have a standalone (unreduced, though) test-case.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Testcase

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Screenshot (that border around the 'done' checkbox' should be completely dashed)

Comment 3

[Emilio Cobos Álvarez [:emilio]]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=cb03b8da2fbfc316a70b836d77483f8971c7fd8b&tochange=74d2f3727afdacaab3d8ec2149efddf2f63025be

Comment 4

[Darkspirit]

Debian Testing, KDE, X11, Macbook Pro, Intel Iris 6100 (Broadwell GT3)
I see it at 110% zoom.

Comment 5

[Darkspirit]

Also reproducible on Win10, Radeon RX480, 2560x1440.
[Tracking Requested - why for this release]: Win10 without battery is affected by default (Nvidia, AMD, Intel).

Comment 6

[Darkspirit]

(Related: If bug 1558135 touched borders, it might be the cause I don't see bug 1555977 as often as before: Sometimes there is still some blinking, but only for a short moment. I don't know.)

Comment 7

[Nicolas Silva [:nical]]

Attachment: Bug 1565910 - Preserve batch features when merging batches. r=gw

Comment 8

[Nicolas Silva [:nical]]

Attachment: Reduced testcase

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f86fb2490cfa
Preserve batch features when merging batches. r=gw

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f86fb2490cfa

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 12

[Nicolas Silva [:nical]]

Comment on attachment 9078157 [details]
Bug 1565910 - Preserve batch features when merging batches. r=gw

Beta/Release Uplift Approval Request

• User impact if declined: Incorrect rendering of dashed/dotted borders under certain circumstances.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple patch.
• String changes made/needed: None.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9078157 [details]
Bug 1565910 - Preserve batch features when merging batches. r=gw

Fixes incorrect rendering of dashed/dotted borders under certain circumstances when WebRender is enabled. Approved for 69.0b6.

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f676fbe4d5e1