1566536 - Support password generation in private windows

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Description

[Matthew N. [:MattN]]

In bug 1566533 we disabled it for the first version but we want to support it eventually. We need to be careful not to persist origins in memory after closing all private windows and handle the less ideal UX where we can't autosave.

Comment 1

[Matthew N. [:MattN]]

Is this something you will work on for Fx71 or will epang?

Comment 2

[rgaddis]

TBD... will find out this week hopefully.

Comment 3

[katieC]

Attachment: PWGeneration_states

[ See Attached screenshot ]

New String: Firefox will save this password for this website
*Note: string should be added to both Private & non-Private windows
Status: Awaiting string review by Betsy

Comment 4

[Matthew N. [:MattN]]

How will we handle the context menu option?

Comment 5

[katieC]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #4)

How will we handle the context menu option?

Working on it :) - related to this bug from Sandy: https://bugzilla.mozilla.org/show_bug.cgi?id=1595915

Comment 6

[katieC]

Matt, based on our conversation... from the context menu, the user selects "Use a Securely Generated Password..."
• Open password field drawer / popUp
• Display PW Generator (see screenshot above)
• If uses clicks out of form and then refocuses, PW Generator no longer there. User has to re-invoke it via the context menu (similar to how Chrome behaves)

Comment 7

[katieC]

Attachment: PWGeneration_ContextMenu_1566536.jpg

Context Menu screenshot/spec (lite)

Comment 8

[Matthew N. [:MattN]]

Ugh… I forgot about an edge-case… if we already have a login with no username saved for this site then we won't auto-save but the string will still claim that we will… should we show/hide the "Firefox will save this password for this website" string depending on whether we will automatically save?

Betsy, I am starting on this bug now so hopefully you can review the string today.

Comment 9

[katieC]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #8)

Ugh… I forgot about an edge-case… if we already have a login with no username saved for this site then we won't auto-save but the string will still claim that we will… should we show/hide the "Firefox will save this password for this website" string depending on whether we will automatically save?

Yes, if we autosave the generated password - show string. If we don't autosave it - hide string.

Comment 10

[Matthew N. [:MattN]]

Attachment: Bug 1566536 - Support password generation in private windows. r=sfoster

• Inform users in autocomplete that using a generated password will cause it to be automatically saved.
• Don't fill generated passwords from the context menu directly, that menu item (renamed) should simply force the generation UI to appear in autocomplete.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57ff77aaedc0
Support password generation in private windows. r=sfoster

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/57ff77aaedc0

Comment 13

[Timea Cernea [:tbabos][inactive]]

(In reply to katieC from comment #6)

• If uses clicks out of form and then refocuses, PW Generator no longer there. User has to re-invoke it via the context menu (similar to how Chrome behaves)

Hey KatieC,

I believe this is only applicable to the fields that DO NOT have the autocomplete="new-password" attribute.
The fields with this attribute will always have the password generation option in the autocomplete dropdown, regardless if the users focus out of the password field.

Is this right?

Comment 14

[katieC]

(In reply to Timea Cernea [:tbabos] from comment #13)

I believe this is only applicable to the fields that DO NOT have the autocomplete="new-password" attribute.
The fields with this attribute will always have the password generation option in the autocomplete dropdown, regardless if the users focus out of the password field.

Is this right?

Yes! that is right - sorry for not including that in the note, thanks for the catch.

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Sorry for the spam, removing the flag, It's already a PI request for this (PI-390)

Comment 16

[ithompson4]

Fix Verified [testday-20191220]