Convert `target.activeConsole` to `target.getFront("console")`
Categories
(DevTools :: Console, enhancement, P1)
Tracking
(Fission Milestone:M6, firefox73 fixed)
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: ochameau, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(8 files, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
ThreadFront and WebConsoleFront are the only two one left having a special codepath in TargetMixin.
These two are special as there is synchronous attributes on the target
object, activeConsole
and threadFront
, in order to get a reference to them.
Their instantiation is also special as you have to call target.attachConsole
as well as target.attachThread
in order to create these attributes.
There is some discrepancies between these two and all the other one which are created on-demand on the first call to target.getFront
:
-
target.attachConsole
is called in middle oftarget.attach
, manually, from each target subclasses:
https://searchfox.org/mozilla-central/search?q=this.attachConsole(&case=false®exp=false&path=shared%2Ffronts%2Ftargets%2F -
target.attachThread
is called from many various callsites:
https://searchfox.org/mozilla-central/search?q=.attachThread(&case=false®exp=false&path=
But the two important callsites if we ignore tests are:
In any case, we should distinguish the two following operation:
- retrieving the front:
target.getFront("xxx")
- "attaching it":
console.startListeners([])
andthread.attach(options)
A first iteration would be to do this split and use target.getFront everywhere.
Then, we could possibly iterate in order to cleanup the various way we are "attaching" these actors.
Why is this important to switch to getFront
?
- enable
target.onFront
to work with these two fronts. Fission is going to force us to support more than one front instance. In a near future, we are going to replace a few calls togetFront
into calls toonFront
. This step will be easier if we are already usinggetFront
. - having a unified codebase. There is no reason but historical ones to have specifics around these two fronts.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Depends on D39471
Assignee | ||
Comment 2•1 year ago
|
||
Depends on D56685
Assignee | ||
Comment 3•1 year ago
|
||
Depends on D56686
Assignee | ||
Comment 4•1 year ago
|
||
Depends on D56688
Assignee | ||
Comment 5•1 year ago
|
||
Depends on D56689
Assignee | ||
Comment 6•1 year ago
|
||
Depends on D56690
Assignee | ||
Comment 7•1 year ago
|
||
Depends on D56691
Assignee | ||
Comment 8•1 year ago
|
||
Depends on D56692
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Assignee | ||
Comment 9•1 year ago
|
||
Comment 10•1 year ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1796a39b020b Remove target.activeConsole usage in DOM panel. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/33c4706a4255 Remove target.activeConsole usage in tests. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/55ac64d74725 Remove target.activeConsole usage in Netmonitor. r=Honza. https://hg.mozilla.org/integration/autoland/rev/4deadf97378f Remove target.activeConsole usage in Debugger. r=jlast. https://hg.mozilla.org/integration/autoland/rev/3c8ef35fde92 Remove target.activeConsole usage in WebConsole. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/b3aea303d3ed Remove target.activeConsole usage in Toolbox. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/da1672f831d1 Remove this.activeConsole in TargetMixin. r=ochameau.
Comment 11•1 year ago
|
||
Backed out 8 changesets (Bug 1566850, Bug 1603035) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281034751&repo=autoland&lineNumber=8474
Comment 12•1 year ago
|
||
Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/535b50b4c504 Backed out 8 changesets (bug 1566850, bug 1603035) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js CLOSED TREE
Assignee | ||
Comment 14•1 year ago
|
||
Depends on D56692
Comment 15•1 year ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6)
Comment 16•1 year ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b043364b1636 Remove target.activeConsole usage in DOM panel. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/63f43d73d53a Remove target.activeConsole usage in tests. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/368e030bee6e Remove target.activeConsole usage in Netmonitor. r=Honza. https://hg.mozilla.org/integration/autoland/rev/75e1e143cd8d Remove target.activeConsole usage in Debugger. r=jlast. https://hg.mozilla.org/integration/autoland/rev/ad57ea430417 Remove target.activeConsole usage in WebConsole. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/6bb8f7988396 Remove target.activeConsole usage in Toolbox. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/8d07872ee7aa Remove target.activeConsole usage in devtools extension code. r=jdescottes,rpl. https://hg.mozilla.org/integration/autoland/rev/0f7053d36328 Remove this.activeConsole in TargetMixin. r=ochameau.
Updated•1 year ago
|
Comment 17•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b043364b1636
https://hg.mozilla.org/mozilla-central/rev/63f43d73d53a
https://hg.mozilla.org/mozilla-central/rev/368e030bee6e
https://hg.mozilla.org/mozilla-central/rev/75e1e143cd8d
https://hg.mozilla.org/mozilla-central/rev/ad57ea430417
https://hg.mozilla.org/mozilla-central/rev/6bb8f7988396
https://hg.mozilla.org/mozilla-central/rev/8d07872ee7aa
https://hg.mozilla.org/mozilla-central/rev/0f7053d36328
Updated•1 year ago
|
Description
•