1567773 - Lists in contenteditable

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect, P3)

Description

[versusvirus]

Attachment: lists_ff.gif

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

1.Create contenteditable
2.Insert list inside
3.in css ul elements must have list-style-postion: inside

Actual results:

The marker is in the wrong position

Expected results:

Marker has correct position

Comment 1

[versusvirus]

https://jsfiddle.net/76tcr21g/

Comment 2

[Alice0775 White]

Rehression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5dc0652cd024fef30217ac3e6087b7a32f16967f&tochange=9bad25ccc8d0414e21d3c8d4dcf2178a97bb07c3

Regressed by: Bug 1518201, Bug 288704, Bug 205202

Comment 3

[Makoto Kato [:m_kato]]

comment was spam...

Comment 4

[Emilio Cobos Álvarez [:emilio]]

(I'll try to take a look since mats is on PTO, but leaving ni? in his queue too just in case I don't get to it)

Comment 5

[Mats Palmgren (inactive)]

I'll take a look...

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Alright, thanks!

Comment 7

[Mats Palmgren (inactive)]

Attachment: Bug 1567773 - [css-lists] Look for an inside ::marker frame too when searching for a suitable sibling. r=emilio

Comment 8

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5da5fe1e58efc238ecceefad8a551a296e5477c7

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/237b431a3ffc
[css-lists] Look for an inside ::marker frame too when searching for a suitable sibling.  r=emilio

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18045 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 13

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/237b431a3ffc

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 15

[Mats Palmgren (inactive)]

Comment on attachment 9079794 [details]
Bug 1567773 - [css-lists] Look for an inside ::marker frame too when searching for a suitable sibling. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: wrong layout of list-item marker after dynamic DOM change
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fairly straight-forward patch.
• String changes made/needed:

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9079794 [details]
Bug 1567773 - [css-lists] Look for an inside ::marker frame too when searching for a suitable sibling. r=emilio

Fixes wrong layout of list-item marker after dynamic DOM changes and includes an automated test. Approved for 69.0b10.

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/6ea8998931b8