Closed Bug 1567773 Opened 7 months ago Closed 7 months ago

Lists in contenteditable

Categories

(Core :: Layout: Generated Content, Lists, and Counters, defect, P3)

68 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox68 --- wontfix
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: versusvirus, Assigned: mats)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image lists_ff.gif

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

1.Create contenteditable
2.Insert list inside
3.in css ul elements must have list-style-postion: inside

Actual results:

The marker is in the wrong position

Expected results:

Marker has correct position

Component: Untriaged → Editor
Keywords: regression
Product: Firefox → Core
Status: UNCONFIRMED → NEW
Ever confirmed: true

comment was spam...

Priority: -- → P1

(I'll try to take a look since mats is on PTO, but leaving ni? in his queue too just in case I don't get to it)

Flags: needinfo?(mats)
Flags: needinfo?(emilio)
Regressed by: 288704

I'll take a look...

Assignee: nobody → mats
Component: Editor → Layout: Generated Content, Lists, and Counters
Flags: needinfo?(mats)
OS: Unspecified → All
Priority: P1 → P3
Hardware: Unspecified → All

Alright, thanks!

Flags: needinfo?(emilio)
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/237b431a3ffc
[css-lists] Look for an inside ::marker frame too when searching for a suitable sibling.  r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18045 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(mats)
Flags: in-testsuite+

Comment on attachment 9079794 [details]
Bug 1567773 - [css-lists] Look for an inside ::marker frame too when searching for a suitable sibling. r=emilio

Beta/Release Uplift Approval Request

  • User impact if declined: wrong layout of list-item marker after dynamic DOM change
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Fairly straight-forward patch.
  • String changes made/needed:
Flags: needinfo?(mats)
Attachment #9079794 - Flags: approval-mozilla-beta?

Comment on attachment 9079794 [details]
Bug 1567773 - [css-lists] Look for an inside ::marker frame too when searching for a suitable sibling. r=emilio

Fixes wrong layout of list-item marker after dynamic DOM changes and includes an automated test. Approved for 69.0b10.

Attachment #9079794 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.