implement list numbering using counters

NEW
Unassigned

Status

()

P3
normal
14 years ago
11 months ago

People

(Reporter: dbaron, Unassigned, Mentored)

Tracking

(Depends on: 1 bug, Blocks: 4 bugs, {css-moz, css3, DevAdvocacy})

Trunk
css-moz, css3, DevAdvocacy
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=c++][DevRel:P3])

Attachments

(1 attachment, 3 obsolete attachments)

Now that we implement counters (bug 3247), using them for list numbering would
fix a significant number of list numbering bugs that we have.

A patch containing some of the necessary code removal is in bug 3247 comment 57
(removed from all later patches).

The code that would need to be added would probably involve implementing
considerable parts of css3-content's proposals for list handling, using -moz-
prefixes.  Note that we probably don't want to use counters for
disc/square/circle/none types since we probably want to keep the customized
drawing code that we use for them.
Blocks: 3246, 241719
Depends on: 3247
Created attachment 179433 [details] [diff] [review]
work in progress

This is the old patch merged to the trunk, plus a few tweaks.

Updated

14 years ago
Blocks: 205202
Keywords: css-moz, css3

Comment 2

14 years ago
Why isn't it called mozMarker internally? Similar to other Mozilla
implementations of CSS3 proposals/extensions?
(In reply to comment #2)
> Why isn't it called mozMarker internally? Similar to other Mozilla
> implementations of CSS3 proposals/extensions?

Because that just creates more work when we want to drop the -moz- (for things
that are in a spec).
(In reply to comment #0)
> Note that we probably don't want to use counters for
> disc/square/circle/none types since we probably want to keep the customized
> drawing code that we use for them.

Well, we do need to use counters so that 'list-style-type' on an individual item
still works.
Created attachment 182626 [details] [diff] [review]
work in progress

Nothing significant here, just some comments reflecting current thoughts.
Attachment #179433 - Attachment is obsolete: true
Created attachment 196712 [details] [diff] [review]
work in progress

For a second I was thinking this would be easy, and then I ran into problems
with the spec; see comments.
Attachment #182626 - Attachment is obsolete: true
I realized that this bug doesn't require implementing ::marker, and given the
dependency on bug 309217 if I want to do it using ::marker, there's probably
good reason to do it without.
Whiteboard: [patch]
And, FWIW, I wasn't thinking straight about the spec problems in those comments;
it's actually fine.

Updated

13 years ago
Flags: blocking1.9a1?

Updated

12 years ago
Flags: blocking1.9a1? → blocking1.9-
Created attachment 246257 [details] [diff] [review]
work in progress

Just a little more work that I had lying around in a tree.
Attachment #196712 - Attachment is obsolete: true
Er, that last patch is smaller -- I think it had the stuff that I thought was step 2 taken out, and maybe a little other work added.

Updated

12 years ago
Blocks: 368880

Updated

11 years ago
No longer blocks: 368880
Is there any chance of this (and related counter stuff) being resurrected any time soon?
Flags: needinfo?(dbaron)
I don't think it's a priority for me right now, though I'd be willing to help mentor someone.  It involves a good bit of discussion with the CSS working group, figuring out the current state of spec proposals/drafts, etc.
Assignee: dbaron → nobody
Flags: needinfo?(dbaron)
Whiteboard: [patch] → [mentor=dbaron]
Whiteboard: [mentor=dbaron] → [mentor=dbaron][lang=c++]
(Assignee)

Updated

4 years ago
Mentor: dbaron
Whiteboard: [mentor=dbaron][lang=c++] → [lang=c++]

Comment 13

4 years ago
Hi I'm new to the Mozilla developers network as well as OSS contribution and want to work on this bug. Any chance I could get some mentored help and a basic how to start?

Thanks!
You probably don't want to try working on this bug until you've successfully worked on a number of other patches first, since this is relatively involved.

Comment 15

2 years ago
::marker pseudo-element returned to the CSS Pseudo Elements module level 4 spec: https://www.w3.org/TR/css-pseudo-4/#marker-pseudo. Would it help fixing this bug now?

It's a pity that we still have the 17-year-old https://bugzilla.mozilla.org/show_bug.cgi?id=4522 blocked by this. Other browsers have no problems with numeric list-style values for any element.
Keywords: DevAdvocacy
Whiteboard: [lang=c++] → [lang=c++][DevRel:P1]

Updated

2 years ago
Priority: -- → P3
Whiteboard: [lang=c++][DevRel:P1] → [lang=c++][DevRel:P3]

Updated

a year ago
Blocks: 1392682

Updated

a year ago
No longer blocks: 1392682
You need to log in before you can comment on or make changes to this bug.