1568133 - React to DOM changes in Mac Menu

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

MacOS does not react to changes to DOM in the menubar. This prevents Fluent migration and runtime language changes.

STR:

1. Open Firefox on MacOS
2. Open Browser Console
3. document.getElementById("file-menu").label = "Foo";
4. Notice that File menu changed to Foo`
5. document.getElementById("menu_preferences").label = "Bar";
6. Expand the Firefox menu

Current result:

Preferences label doesn't get updated to Bar

Expected result:

Preferences label gets updated to Bar

The two attributes that will get pulled out of L10n are label and accesskey.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Stephen - can you unblock me here?

Comment 2

[Stephen A Pohl [:spohl]]

It looks like you are running into what is described in bug 1333781 comment 0. That's specific to access keys, but it must be applicable to labels as well.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Stephen - can you triage this? We're now ready to migrate the startup path to Fluent and this bug is the only blocker for the menu bar migration (bug 1501886).

Comment 4

[Stephen A Pohl [:spohl]]

I've gone ahead and assigned a priority, but since:

1. I'm typically the one working on these issues,
2. this is not a straightforward thing to fix,
3. the fact that I am about to be on PTO for two weeks, and
4. that there is a lot of other work I need to wrap up before my PTO

I am not confident that this will be addressed from the widget/cocoa side on a particularly fast timeline. If there is someone on your team with macOS experience I would recommend that they take a look instead.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks!

I don't think there is. I went ahead and removed the 6 strings from the bug 1501886 and put the comment that we need to wait for this bug to migrate them.

I'll likely move this bug to block the wider "migrate startup path off of DTD" meta-bug.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hi Stephen, this is blocking bug 1579477 which we're going to focus on next. Would you be able to provide any ETA assuming current priorities?

Comment 7

[Stephen A Pohl [:spohl]]

Unfortunately, I don't expect to be able to work on this before November. We are currently putting together a proposal to focus more on macOS-specific issues such as this one, but even if approved it would only become a Q1 2020 OKR.

Comment 8

[Brendan Dahl [:bdahl]]

I have some patches I'll put up in a bit that should get us most of the way.

1. Don't build the application menu until l10n is ready
2. Ensure the application menu is rebuilt when the application menu changes in the hidden window

This still doesn't let us have an application menu per window, but for most of what fluent needs it should suffice.

Comment 9

[Brendan Dahl [:bdahl]]

Attachment: Bug 1568133 - Wait to load MacOS app menu until l10n is ready. r=mstange!

Enables using fluent for the application menu bar strings.

Comment 10

[Brendan Dahl [:bdahl]]

Attachment: Bug 1568133 - Migrate the rest of the menubar to Fluent. r=Gijs!,flod!

Depends on D46202

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

@sphol - the issue is not related to localization, but Widget: Cocoa. It requires Cocoa bindings in Cocoa component in Gecko to work. Can you please revisit your last change?

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

Brendan - can you assess this? It's blocking some of the Fluent migrations. Is there something actionable that I could do to help you with landing this?

Comment 13

[Brendan Dahl [:bdahl]]

It's stuck on the fluent migration (maybe it's easier now). If someone can update the migration I can get a review for the code changes.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Let me see if I can sort out that migration.

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Tentatively commandeering. Let me know if I'm out of line here, bdahl.

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Going to wait for bug 1660848 lands before I land this.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/991140be037c
Wait to load MacOS app menu until l10n is ready. r=mstange
https://hg.mozilla.org/integration/autoland/rev/b559da4d69e5
Migrate the rest of the menubar to Fluent. r=fluent-reviewers,flod,Gijs

Comment 18

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/991140be037c
https://hg.mozilla.org/mozilla-central/rev/b559da4d69e5