Closed Bug 1683419 Opened 1 year ago Closed 11 months ago

Fork the Help menubar strings so that the AppMenu can have them be in sentence case for en-US

Categories

(Firefox :: General, task)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-foundations])

Attachments

(1 file)

As it says on the tin. Each item inside of the Help menu has a pre-existing Fluent string like menu-help-not-deceptive.

I plan to introduce a convention where the AppMenu variant is prefixed with app, so appmenu-help-not-deceptive.

I'll also be adding a test to ensure that the Help menu and AppMenu help panel contain the same items to help prevent situations where someone forgets to add the appmenu variants.

Notable is the aboutName element still using DTD here: https://searchfox.org/mozilla-central/rev/58e955b8005b4845c42e874a6b9aa5b223ef0d82/browser/base/content/browser-menubar.inc#511-514

I'll see if I can push bug 1568133 along to make this easier. If I can't, I guess I'll special-case that node.

Huh, today, when I run the Fluent migration with ./mach fluent-migration-test python/l10n/fluent_migrations/bug_1683419_forking_help_menu.py, I get this:

Running migration fluent_migrations.bug_1683419_forking_help_menu for en-US
  Writing to /Users/mikeconley/Projects/mozilla-central/obj-artifact/python/l10n/bug_1683419_forking_help_menu/en-US/browser/browser/appmenu.ftl
  Committing changeset: Bug 1683419 - Fork the Help menu strings for use in the AppMenu, part 1.
  Writing to /Users/mikeconley/Projects/mozilla-central/obj-artifact/python/l10n/bug_1683419_forking_help_menu/en-US/browser/browser/appmenu.ftl
  Committing changeset: Bug 1683419 - Fork the Help menu strings for use in the AppMenu, part 2.
--- /Users/mikeconley/Projects/mozilla-central/obj-artifact/python/l10n/bug_1683419_forking_help_menu/reference/browser/browser/appmenu.ftl
+++ /Users/mikeconley/Projects/mozilla-central/obj-artifact/python/l10n/bug_1683419_forking_help_menu/en-US/browser/browser/appmenu.ftl
@@ -42,9 +42,6 @@

 ## Help panel

-appmenu-about =
-    .label = About { -brand-shorter-name }
-    .accesskey = A
 appmenu-help-product =
     .label = { -brand-shorter-name } Help
     .accesskey = H
@@ -81,5 +78,3 @@
 appmenu-help-not-deceptive =
     .label = This Isn’t a Deceptive Site…
     .accesskey = D
-appmenu-help-check-for-update =
-    .label = Check for Updates…

Any idea what I'm doing wrong here, zibi?

Flags: needinfo?(zbraniecki)

My only guess is that the reference en-US repository wasn't yet updated with menu-about ID that landed yesterday.

Unfortunately the migration script is not vocal about the issues it encounters and it just quietly drops the entries it cannot resolve :(

Flags: needinfo?(zbraniecki)

Do you know when the reference en-US repo gets updated?

Flags: needinfo?(francesco.lodolo)

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #4)

Do you know when the reference en-US repo gets updated?

It's a manual process, so when I can (i.e. when I have time to run migrations on all repositories and there are no other blockers).

There was another r+ patch in queue with a migration (this bug), so I was waiting to see if it landed to run both of them together, given it's an operation that requires a lot of time.

I would suggest to ignore the IDs unrelated to this patch for now. They should be relatively easy to spot, but feel free to ping me if you want someone to double check them.

Flags: needinfo?(francesco.lodolo)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3679ce4e1261
Fork Help menu strings for use in the AppMenu. r=Gijs,flod,fluent-reviewers
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Regressions: 1692083
You need to log in before you can comment on or make changes to this bug.