1568227 - Use the visible rect as the blob image size

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use visible rect

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use visible rect (rebased)

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Untested patch that allows more resizing

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1568227. Render blobs at visibleRect.x,y instead of 0,0.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1568227. Use the visible rect as the display items bounds for fallback items.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1568227. Remove offset from visible rect.

This stops making the visible rect relative to the bounds of the image.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1568227. Change to using the visual rect for the blob bounds.

This also makes sure that we invalidate for any visible rect bounds changes.
This makes more sense even if it's more conservative.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb324781c1e3
Render blobs at visibleRect.x,y instead of 0,0. r=nical
https://hg.mozilla.org/integration/autoland/rev/fef155ac9c60
Use the visible rect as the display items bounds for fallback items. r=nical

Comment 9

[Razvan Maries]

Backed out for perma fails on paint-order-001.tentative.html.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cquantumrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-linux64-qr%2Fdebug-web-platform-tests-reftests-e10s-5%2Cw%28wr5%29&revision=fef155ac9c6039de75923334a75c03d7aa5ab156&selectedJob=265951499

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=265951499&repo=autoland&lineNumber=20128

Backout: https://hg.mozilla.org/integration/autoland/rev/35e9f24cc4c92b6e829dbc974c649c2399da8932

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b188ca5e00bb
Render blobs at visibleRect.x,y instead of 0,0. r=nical
https://hg.mozilla.org/integration/autoland/rev/9163b1b1da06
Use the visible rect as the display items bounds for fallback items. r=nical

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b17e84b9bf8
Remove offset from visible rect. r=nical
https://hg.mozilla.org/integration/autoland/rev/7fa90877a45b
Change to using the visual rect for the blob bounds. r=nical

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b188ca5e00bb
https://hg.mozilla.org/mozilla-central/rev/9163b1b1da06
https://hg.mozilla.org/mozilla-central/rev/3b17e84b9bf8
https://hg.mozilla.org/mozilla-central/rev/7fa90877a45b