Closed Bug 1568825 Opened 2 months ago Closed Last month

Prepare the node-picker for being able to eventually select elements across targets

Categories

(DevTools :: Inspector, enhancement, P1)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission)

Attachments

(3 files)

With Fission, the element picker in the toolbox should be able to pick elements that are inside oop frames (or remote browsers in the context of the browser toolbox).

For this to be possible, we need to first prepare the node-picker module in a way that it can easily be made multi-target-aware.

Priority: P3 → P2
Whiteboard: dt-fission
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Priority: P2 → P1
Depends on: 1572460

I ended up rebasing the patches since I was kinda blocked on them.

Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/515ff404fcfe
1 - Moving node-picker.js to the client r=gl
https://hg.mozilla.org/integration/autoland/rev/36627f38d627
2 - Moving the nodePicker singleton to the toolbox r=gl
https://hg.mozilla.org/integration/autoland/rev/e1193c2352a1
3 - Remove the nodePicker's dependency on highlighter and walker r=gl
Summary: Make it possible for the element picker to select elements also in oop frames → Prepare the node-picker for being able to eventually select elements across targets
Blocks: 1574401
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.