1568880 - Make the inspector's search field work with remote targets

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Patrick Brosset <:pbro>]

With Fission and when bug 1560200 is fixed, the markup-view will be displaying the DOM tree found in remote targets (oop iframes or remote browsers in the Browser Toolbox).

The search input field in the inspector will need to be adapted once that happens.

• It will need to be capable or returning auto-completion hints that also match nodes found in remote targets
• It will need to return all matching results once a search is submitted, even for notes found in remote targets
• It will need to be capable of selecting the resulting nodes in the markup-view.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6)

Comment 2

[Chris Peterson [:cpeterson]]

dt-fission-reserve bugs do not need to block Fission Nightly (M6).

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Simple test case and STRs, so it's easy to reproduce:

STR:

1. Load http://janodvarko.cz/tests/fission/case1/index.html
2. Open DevTools Toolbox and select the Inspector panel
3. Search for POST
4. The POST in top level document is highlighted but the one in remote iframe is not -> BUG
   Honza

Comment 4

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m3-mvp bugs for Fission Beta milestone (M7).

Comment 5

[Neha Kochar [:neha]]

Bulk move of all dt-fission-m3-mvp bugs to Fission MVP milestone.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Comment 3 is still valid.

The search feature is using the top-level target WalkerActor#search method (devtools/server/actors/inspector/walker.js#1308-1319), which lives in the content process.

We'd need to go through all the different targets on the page to agglomerate the results on each of them before returning the results to the client.
For iterating over the different results, the inspector uses selection.setNodeFront, which should work seamlessly.

Comment 8

[Chris Peterson [:cpeterson]]

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Comment 9

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1568880 - [devtools] Use Inspector command to implement cross target node search

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c69522fbe288
[devtools] Use Inspector command to implement cross target node search r=nchevobbe,jdescottes

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c69522fbe288