Open Bug 1568880 Opened 2 years ago Updated 9 days ago

Make the inspector's search field work with remote targets

Categories

(DevTools :: Inspector, task, P3)

task

Tracking

(Fission Milestone:M8)

ASSIGNED
Fission Milestone M8

People

(Reporter: pbro, Assigned: bomsy)

References

(Blocks 4 open bugs)

Details

(Whiteboard: dt-fission-m3-mvp)

Attachments

(1 file)

With Fission and when bug 1560200 is fixed, the markup-view will be displaying the DOM tree found in remote targets (oop iframes or remote browsers in the Browser Toolbox).

The search input field in the inspector will need to be adapted once that happens.

  • It will need to be capable or returning auto-completion hints that also match nodes found in remote targets
  • It will need to return all matching results once a search is submitted, even for notes found in remote targets
  • It will need to be capable of selecting the resulting nodes in the markup-view.
Priority: P3 → P2
Whiteboard: dt-fission
Depends on: 1575237
Priority: P2 → P3
Whiteboard: dt-fission → dt-fission-reserve

Tracking Fission DevTools bugs for Fission Nightly (M6)

Fission Milestone: --- → M6

dt-fission-reserve bugs do not need to block Fission Nightly (M6).

Fission Milestone: M6 → ---

Simple test case and STRs, so it's easy to reproduce:

STR:

  1. Load http://janodvarko.cz/tests/fission/case1/index.html
  2. Open DevTools Toolbox and select the Inspector panel
  3. Search for POST
  4. The POST in top level document is highlighted but the one in remote iframe is not -> BUG
    Honza
Has STR: --- → yes
Whiteboard: dt-fission-reserve → dt-fission-reserve, dt-fission-m3-mvp

Tracking dt-fission-m3-mvp bugs for Fission Beta milestone (M7).

Fission Milestone: --- → M7
Whiteboard: dt-fission-reserve, dt-fission-m3-mvp → dt-fission-m3-mvp

Bulk move of all dt-fission-m3-mvp bugs to Fission MVP milestone.

Fission Milestone: M7 → MVP
Type: enhancement → task
Duplicate of this bug: 1682965

Comment 3 is still valid.

The search feature is using the top-level target WalkerActor#search method (devtools/server/actors/inspector/walker.js#1308-1319), which lives in the content process.

We'd need to go through all the different targets on the page to agglomerate the results on each of them before returning the results to the client.
For iterating over the different results, the inspector uses selection.setNodeFront, which should work seamlessly.

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Fission Milestone: MVP → M7
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Fission Milestone: M7 → M8
Assignee: poirot.alex → hmanilla
You need to log in before you can comment on or make changes to this bug.