1569513 - Tasks lists should only be filled when first visible

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Like bug 1568723, the lists of tasks in the Today Pane and in the Tasks tab are filled at start-up, even if they are not visible. This should be delayed until the UI appears.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1569513-task-tree-lazy-1.diff

• new CalendarTaskTreeView is now called only once per tree, instead of on every call to refresh.
• updateFilter gets called when each tree appears, and this calls refresh. This was already happening for the Tasks tab (so the initial load is completely unnecessary!), and is now done at the appropriate time in the Today Pane by calling prepareCalendarToDoUnifinder.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9081178 [details] [diff] [review]
1569513-task-tree-lazy-1.diff

Review of attachment 9081178 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!  Thanks for the improvements to the task tree code.  Changes look good and the task lists in the tab and the today pane were populated as expected when I tested this.  r+ with a couple comments to address.

::: calendar/base/content/calendar-unifinder-todo.js
@@ +20,5 @@
>   * Updates the applied filter and show completed view of the unifinder todo.
>   *
>   * @param aFilter        The filter name to set.
>   */
>  async function updateCalendarToDoUnifinder(aFilter) {

"async" no longer needed here.

::: calendar/base/content/today-pane.js
@@ +116,3 @@
>              }
> +            if (todoIsVisible) {
> +                prepareCalendarToDoUnifinder();

This "setTodayHeader" function now seems to be doing more than its name indicates.  Might be worth renaming it or something similar to make things easier to follow.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1569513-task-tree-lazy-2.diff

Comment 4

[Geoff Lankow (:darktrojan)]

Bug 1568723 needs to land first.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ce4fab069c39
Load tasks lists only when first visible. r=pmorris DONTBUILD

Comment 6

[Paul Morris [:pmorris]]

Attachment: esr68-1569513-task-tree-lazy-2.diff

I'm porting this patch to esr68 to fix bug 1581411. This also entails porting the patch from bug 1568723 (since this patch depends on it).

Comment 7

[Paul Morris [:pmorris]]

Try server run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=28727ff968e8f7dfd372b4685d7019ba980168b9

Comment 8

[Jorg K (CEST = GMT+2)]

TB 68.1.2 or TB 68.2 / Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/b54334fbfbeaaa04595387264e8af98458379e62

Comment 9

[Jorg K (CEST = GMT+2)]

That patch was wrong, see bug 1560547 comment #37. At least here:
https://hg.mozilla.org/releases/comm-esr68/rev/b54334fbfbeaaa04595387264e8af98458379e62#l4.58

Comment 10

[Jorg K (CEST = GMT+2)]

We'll fix in in bug 1568723.