1569784 - Extra space below search and above Top Sites on New Tab

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, defect, P2)

Description

[Punam Dahiya [:pdahiya]]

With new profiles extra space is seen above top sites in latest nightly with new profiles. This issue is not replicable for older profiles hinting it could be snippet issue. Opening bug for QA to verify. Thanks

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: extra-space-above-topsites.png

Comment 2

[Punam Dahiya [:pdahiya]]

Some more finding

Window size with old profile is 1425 x700 which kicks in padding here https://github.com/mozilla/activity-stream/blob/master/content-src/components/Search/_Search.scss#L159

window size with new profile is 1425x722 which kicks in default padding here https://github.com/mozilla/activity-stream/blob/master/content-src/components/Search/_Search.scss#L9

Comment 3

[Punam Dahiya [:pdahiya]]

Based on above finding, looks like its working as intended. Its just frustrating as 700px benchmark barely touches the end of top stories hiding bottom border, increasing window height applies padding and still keeps bottom border of first row of top stories hidden.

Increasing max-height threshold to 720px should help avoid this confusion. NI @wolasi for his take and resolve issue accordingly. Thanks

Comment 4

[Wolasi :wolasi]

Why the change in top and bottom padding for search for new profile? Can we git blame to find out who made the change and why?

Comment 5

[Punam Dahiya [:pdahiya]]

Sorry for confusion in initial description, its for all profiles and this change was done with fix of https://github.com/mozilla/activity-stream/pull/4298

Comment 6

[Jeane Carlos]

(In reply to Punam Dahiya [:pdahiya] from comment #5)

Sorry for confusion in initial description, its for all profiles and this change was done with fix of https://github.com/mozilla/activity-stream/pull/4298

Should we increase/change the breakpoint we add padding under the Search bar later so we can fully show the cards for smaller resolutions?

@pdahiya clarified that this only happens in the default mac resolution for Sierra and under when you disable the Macbook Dock bottom bar.

Comment 7

[Petruta Horea [:phorea], Desktop Test Engineering]

NTP redesign will be done in bug 1709930. There is still extra space in the new Figma spec, so I'm closing this bug as RWFM.
Please reopen and block the new design spec if needed. Thank you!