Closed Bug 1571493 Opened 5 years ago Closed 4 years ago

Decouple the media control from AudioChannelService

Categories

(Core :: Audio/Video: Playback, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla73
Tracking Status
firefox73 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

Details

Attachments

(5 files, 1 obsolete file)

In bug 1565689, we implement a centralized media control service in the chrome process which can control all media running in different content processes. For now, we use the implementation of the AudioChannelService to achieve controlling media, but I think it would be good to decouple them in the future, because AudioChannelSerivce itself has been too complicated from its original purpose, which is used to mute/unmute media.

Depends on: 1601144
Depends on: 1604987
Attachment #9116583 - Attachment description: Bug 1571493 - part5 : support 'ControlledMediaState' in media controller → Bug 1571493 - part4 : support 'ControlledMediaState' in media controller
Attachment #9116582 - Attachment is obsolete: true
Attachment #9116584 - Attachment description: Bug 1571493 - part6 : use 'MediaControlKeysEventHandler' to deliver control keys event. → Bug 1571493 - part5 : use 'MediaControlKeysEventHandler' to deliver control keys event.
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/006160f3a043
part1 : implement 'ContentMediaController' which is used to notify 'MediaControlKeysEvent' for controlled media. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/ff27240d2c1d
part2 : use 'MediaControlAgent' in media element. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/e45cf42b2bc2
part3 : notify media state and audible state changes. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/d5c728d8c206
part4 : support 'ControlledMediaState' in media controller r=chunmin
https://hg.mozilla.org/integration/autoland/rev/3ef1b8838276
part5 : use 'MediaControlKeysEventHandler' to deliver control keys event. r=chunmin
Blocks: 1606782
Regressions: 1607051
Regressions: 1620113
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: