1571663 - Attachment area too high when there is more than one attachment

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: too high.png

I've just noticed this now in my TB 68 ESR pre-release. If there's more than one attachment, like two attachments, the area is too high, see screenshot. Should be the same height as for one attachment which works OK.

Comment 1

[Jorg K (CEST = GMT+2)]

Same issue in Daily.

Comment 2

[alta88]

In addition to this, there is a regression on win only (maybe mac too), where a detached/external attachment does not appear like a link, the .text-link color is overridden. I think it's due to .text-link no longer being added to the child node post de-xbl. This is an important visual.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: 1571663-attachment-area.patch

So, apparently the richlistbox automatically increases its height to show 2 richlistitems, ignoring the orient="horizontal" attribute.
Wrapping that element around an hbox seems to do the trick.
Can you guys help me thoroughly test this to be sure we're not introducing other regressions or UI issues?

Richard, can you help for macos testing?

Comment 4

[Alessandro Castellani [:aleca]]

(In reply to alta88 from comment #2)

In addition to this, there is a regression on win only (maybe mac too), where a detached/external attachment does not appear like a link, the .text-link color is overridden. I think it's due to .text-link no longer being added to the child node post de-xbl. This is an important visual.

I don't have Windows, currently testing on mac.
Can you open a dedicated bug with a screenshot and assign it to me, please?
Thanks

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9083479 [details] [diff] [review]
1571663-attachment-area.patch

Seems to work. I'm no expert with this stuff (and Richard is peer).

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: link-when-hovered.png

Well, there is an underline shown for a link when hovered. If not hovered, it looks like the others.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9083479 [details] [diff] [review]
1571663-attachment-area.patch

Let's assume this passes review ;-)

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9083479 [details] [diff] [review]
1571663-attachment-area.patch

Thanks, Alessandro.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d12044b6279
fix height of attachment pane. r=Paenglab DONTBUILD

Comment 10

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/a61be5648f73a0f3f9c4748e23bc9873aa6f28d8

Comment 11

[Jorg K (CEST = GMT+2)]

TB 69 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/16a23290aead7ae74a967f509e1fc14bdf558b6a