Closed Bug 1572106 Opened 4 months ago Closed 4 months ago
Fix attachment item .text-link decoration on win
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Comment on attachment 9083717 [details] [diff] [review] 1572106-attachmentItem-color.patch The original code set .text-link on the .attachmentcell-name element. It was done to prevent exactly this kind of css hackery and divergence into platform specific workarounds. Several bugs later (boxobject, de-xbl) this was lost. ``` + let name = attachmentitem.boxObject.firstChild + .getElementsByClassName("attachmentcell-name"); + name.classList.add("text-link"); ``` I think for the sanity of anyone maintaining the css (you :)) it would be better to do a querySelector to get .attachmentcell-name element and set .text-link there rather than the attachmentitem ancestor.
Comment on attachment 9083786 [details] [diff] [review] 1572106-attachmentItem-color.patch Yes, thanks! r+ on inspection.
Attachment #9083786 - Flags: review?(alta88) → review+
Comment on attachment 9083786 [details] [diff] [review] 1572106-attachmentItem-color.patch The other attachment bugs (bug 1562200 and bug 1563793) have ESR68 approval too.
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
You need to log in before you can comment on or make changes to this bug.