1572106 - Fix attachment item .text-link decoration on win

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[alta88]

+++ This bug was initially created as a clone of Bug #1571663 +++

(In reply to alta88 from comment #2)

In addition to this, there is a regression on win only (maybe mac too), where a detached/external attachment does not appear like a link, the .text-link color is overridden. I think it's due to .text-link no longer being added to the child node post de-xbl. This is an important visual.

(In reply to Jorg K (GMT+2) from comment #6)

Created attachment 9083483 [details]
link-when-hovered.png

Well, there is an underline shown for a link when hovered. If not hovered, it looks like the others.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1572106-attachmentItem-color.patch

This fixes the issue and also removes a unneeded colour for the size text which makes it unreadable with dark theme.

Comment 2

[alta88]

Comment on attachment 9083717 [details] [diff] [review]
1572106-attachmentItem-color.patch

The original code set .text-link on the .attachmentcell-name element. It was done to prevent exactly this kind of css hackery and divergence into platform specific workarounds. Several bugs later (boxobject, de-xbl) this was lost.
```
+      let name = attachmentitem.boxObject.firstChild
+                               .getElementsByClassName("attachmentcell-name");
+      name[0].classList.add("text-link");
```
I think for the sanity of anyone maintaining the css (you :)) it would be better to do a querySelector to get .attachmentcell-name element and set .text-link there rather than the attachmentitem ancestor.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1572106-attachmentItem-color.patch

Is this what you had in mind?

Comment 4

[alta88]

Comment on attachment 9083786 [details] [diff] [review]
1572106-attachmentItem-color.patch

Yes, thanks! r+ on inspection.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9083786 [details] [diff] [review]
1572106-attachmentItem-color.patch

The other attachment bugs (bug 1562200 and bug 1563793) have ESR68 approval too.

Comment 6

[Jorg K (CEST = GMT+2)]

So the colour is some link colour (blue-ish) but the underline only comes on when hovered. That's intentional?

Comment 7

[alta88]

Yes, the original patch was for CVE level spoofing issues, so the intent was to make external attachments different from internal attachments, and the very common behavior is blue for a link, underline on hover and show the url.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/45b5c5bb3fe6
On Windows show the detached attachment text with the hyperlinktext color. r=alta88

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/5992006459d44f0c07a5be51648914920ff635f3

Comment 10

[Jorg K (CEST = GMT+2)]

TB 69 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/8dd24940ccfa4d13dad9490e14a875634de79be7