1571700 - The Fill Password/Login context menu shows on about: pages

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: use_a_password_generated.mp4

[Notes]:

• The "Use a Securely Generated Password" context menu option is available on "about:logins" page, only after a password was generated on other websites. However, after the option is available on "about:logins" page, the option doesn't work if it's used, no password is generated.-

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-05) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Steps to reproduce]:

1. Open the browser and navigate to the "about:logins" page.
2. Click on the “Create New Login” button.
3. Right click on the password field and hover the "Fill Password" option.
4. Observe the sub-context menu.

[Expected result]:

• The "Use a Securely Generated Password" option from the sub-context menu of the password field is displayed.

[Actual result]:

• The "Use a Securely Generated Password" option from the sub-context menu of the password field is not displayed.

[Regression]

• The issue is not reproducible with older Nightly 70.0a1 builds. Considering this, using mozregression tool I have found the issue that broke this in the latest Nightly build. Here are the results:
• Pushlog: https://tinyurl.com/y6nfgy5n
• Last good revision: f4fb2058c3e94df4261893654e4f72e04ca5793c
• First bad revision: 06f72b9d9d144e098cc74d8cedb71e460c3fabee

From this pushlog it seems that bug 1569093 introduced this behavior.

[Additional notes]:

• Attached a screen recording with the issue.

Comment 1

[Matthew N. [:MattN]]

It wasn't really required to work on about:logins but I guess an error is getting thrown due to about:logins being special. The Browser Console would show it probably. Marking as P2 since we should fix it since there is an error and double separator but it's not a blocker IMO.

Comment 3

[Sam Foster [:sfoster] (he/him)]

I'm planning on not showing the fill-login* elements for all about: pages. Or is that over-zealous?
I.e. adding a !documentURI.schemeIs("about") condition to https://searchfox.org/mozilla-central/rev/03853a6e87c4a9405fce1de49e5d03b9e7a7a274/browser/base/content/nsContextMenu.js#987

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1571700 - Don't show fill logins context menu item in about: pages. r?MattN

• Skip showing the password manager items in the context menu from an about: page

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f0f0bb22d79
Don't show fill logins context menu item in about: pages. r=MattN

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7f0f0bb22d79

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 70.0a1 (2019-08-2) (64-bit) on Windows 7 64, MacOS 10.14 and Ubuntu 16.04.

• The Fill Password/Login context menu is no longer available on "about:*" pages.