Closed Bug 1572138 Opened 11 months ago Closed 10 months ago

Introduce status bar for the Search side panel

Categories

(DevTools :: Netmonitor, enhancement, P4)

enhancement

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: Honza, Assigned: lloanalas)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

The search side panel should show a status bar with the following info:

  • Status - e.g. Search finished
    The following search status types should be utilized (see constants.js)
// Search status types
const SEARCH_STATUS = {
  INITIAL: "INITIAL",
  FETCHING: "FETCHING",
  CANCELLED: "CANCELLED",
  DONE: "DONE",
  ERROR: "ERROR",
};
  • Number of results found
    Found 69 matching lines in 17 files.

More comments

  • Everything should be localized
  • Use %s placeholder to add numbers/values into the string dynamically
  • The data as well as the search current state is stored in the Search reducer.

You might see an existing StatusBar for WS panel:
https://searchfox.org/mozilla-central/rev/e0b0c38ee83f99d3cf868bad525ace4a395039f1/devtools/client/netmonitor/src/components/websockets/StatusBar.js#46

Honza

Honza

Priority: -- → P4
Assignee: nobody → lloanalas
Status: NEW → ASSIGNED
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c02697a028d
Introduce status bar for the search side panel. r=Honza,flod.
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.