Closed Bug 1454312 Opened 2 years ago Closed 2 months ago

Display search results when searching across all network resources

Categories

(DevTools :: Netmonitor, enhancement, P2)

enhancement

Tracking

(relnote-firefox ?, firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
relnote-firefox --- ?
firefox70 --- fixed

People

(Reporter: Honza, Assigned: lloanalas)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-needed)

Attachments

(2 files, 2 obsolete files)

Attached image search-in-headers.jpg
It should be possible to search for text across all headers. See an example in the attached screenshot.

This bug is about the UI that renders search results
The core search logic should be implemented in bug 1559347

Honza
Priority: -- → P3
Severity: normal → enhancement
Product: Firefox → DevTools

Would like to pick up this one :)

So first let me sort out what should be done for this feature:

  1. A search component, which shows up when keyboard event ctrl+F raised
  2. The search component should contain two sub-component:
    a) action bar => used to input search text and some user actions(clear, reload)
    b) result list => used to show the matched results
  3. When click result item, should navigate to the corresponding request, and highlight the matching text
  4. Scope for searching: headers, response, cookies and params

Does it seem good to you, or do you have any suggestions or additional details that should be added? :) @honza

:Laphets, thanks for jumping in.

I opened a UX here to pull in some https://github.com/firefox-devtools/ux/issues/59

If you don't want to be blocked, you can probably start prototyping the backend and how to show the contextual matches.

Hi Harald, thanks for your support! Sure, will begin working on the text matching backend :)

Depends on: 1559347
Priority: P3 → P2
Summary: Search for text across all network headers → Search for text across all network resources
Summary: Search for text across all network resources → Display search results when searching across all network resources
Attached patch Search UI Skeleton (obsolete) — Splinter Review

Simple skeleton showing how the UI should be done.

Honza

Assignee: nobody → odvarko
Assignee: odvarko → lloanalas
Status: NEW → ASSIGNED
Attached patch Search UI Skeleton (obsolete) — Splinter Review

Example of Tree component usage.

Honza

Attachment #9077375 - Attachment is obsolete: true
Attachment #9077379 - Attachment is obsolete: true
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc356235b39c
Display search results when searching across all network resources. r=Honza,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Honza, I guess that could be something for the Firefox release notes, don't you think?

Sebastian

Flags: needinfo?(odvarko)
Keywords: dev-doc-needed
QA Whiteboard: [qa-70b-p2]

Chris, this would be important for 71 dev release notes and Netmonitor documentation.

Flags: needinfo?(cmills)

Release Note Request (optional, but appreciated)
[Why is this notable]: Developers could not search through network requests before, unable to find specific.
[Affects Firefox for Android]: No.
[Suggested wording]: With new resource search in DevTools you can quickly find resources based on their request and response data, including headers, cookies and content.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor

relnote-firefox: --- → ?
Flags: needinfo?(odvarko)

(In reply to :Harald Kirschner :digitarald from comment #10)

Chris, this would be important for 71 dev release notes and Netmonitor documentation.

Thanks! Recorded here in the MDN content roadmap: https://trello.com/c/dE8tJ7my/87-network-monitor-enhancements-fx-71

Flags: needinfo?(cmills)
You need to log in before you can comment on or make changes to this bug.