1454312 - Display search results when searching across all network resources

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: search-in-headers.jpg

It should be possible to search for text across all headers. See an example in the attached screenshot.

This bug is about the UI that renders search results
The core search logic should be implemented in bug 1559347

Honza

Comment 1

[Laphets [:Laphets]]

Would like to pick up this one :)

So first let me sort out what should be done for this feature:

1. A search component, which shows up when keyboard event ctrl+F raised
2. The search component should contain two sub-component:
   a) action bar => used to input search text and some user actions(clear, reload)
   b) result list => used to show the matched results
3. When click result item, should navigate to the corresponding request, and highlight the matching text
4. Scope for searching: headers, response, cookies and params

Does it seem good to you, or do you have any suggestions or additional details that should be added? :) @honza

Comment 2

[:Harald Kirschner :digitarald]

:Laphets, thanks for jumping in.

I opened a UX here to pull in some https://github.com/firefox-devtools/ux/issues/59

If you don't want to be blocked, you can probably start prototyping the backend and how to show the contextual matches.

Comment 3

[Laphets [:Laphets]]

Hi Harald, thanks for your support! Sure, will begin working on the text matching backend :)

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Search UI Skeleton

Simple skeleton showing how the UI should be done.

Honza

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Search UI Skeleton

Example of Tree component usage.

Honza

Comment 6

[lloan alas:[lloanalas]]

Attachment: Bug 1454312 - Display search results when searching across all network resources. r=honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc356235b39c
Display search results when searching across all network resources. r=Honza,nchevobbe

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dc356235b39c

Comment 9

[Sebastian Zartner [:sebo]]

Honza, I guess that could be something for the Firefox release notes, don't you think?

Sebastian

Comment 10

[:Harald Kirschner :digitarald]

Chris, this would be important for 71 dev release notes and Netmonitor documentation.

Comment 11

[:Harald Kirschner :digitarald]

Release Note Request (optional, but appreciated)
[Why is this notable]: Developers could not search through network requests before, unable to find specific.
[Affects Firefox for Android]: No.
[Suggested wording]: With new resource search in DevTools you can quickly find resources based on their request and response data, including headers, cookies and content.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor

Comment 12

[Chris Mills [:cmills]]

(In reply to :Harald Kirschner :digitarald from comment #10)

Chris, this would be important for 71 dev release notes and Netmonitor documentation.

Thanks! Recorded here in the MDN content roadmap: https://trello.com/c/dE8tJ7my/87-network-monitor-enhancements-fx-71

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Adding to the release notes, thanks!

Comment 14

[Janet Swisher]

Documented in new article section: https://wiki.developer.mozilla.org/en-US/docs/Tools/Network_Monitor/request_list#Search_in_requests