Closed Bug 1559347 Opened 5 years ago Closed 5 years ago

Implement generic search across all resources

Categories

(DevTools :: Netmonitor, enhancement, P2)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: Honza, Assigned: lalas)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Implement generic search across all resources.

The implementation should include:

  1. Implement proper Redux actions + reducer for search related data
  2. Fetch all details for all resources
  3. Search through all resource objects
  4. Generate search results and store them in the reducer.

This bug doesn't cover the UI (the UI should be done in bug 1454312)

Honza

Assignee: nobody → lloanalas
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch search-concept.patch (obsolete) — Splinter Review

@Lloan: please look at the attached patch. It demonstrates basic concept of the search functionality.

  • Search (Redux) actions and reducer
  • Integration with the context menu
  • Fetching all resource details from the backend
  • Searching across all resources

The patch isn't finished, but it nicely shows what should be done here.
Please look at the patch and prepare list of questions

Thanks!

Honza

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Type: defect → enhancement
Attached patch search-concept.patch (obsolete) — Splinter Review

Rebasing on top of m-c

Honza

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #3)

Created attachment 9073389 [details] [diff] [review]
search-concept.patch

Rebasing on top of m-c

Honza

Current patch has the patch files you put together. Working on implementing the actual searching now. Mixed a few files up between your first patch and the updated patch, but think everything cleared up now.

Thanks!

ok, sounds great!

Honza

Questions:

So you see how i have 2 search results for that resource matching my query string? Okay - for items where it matches the 'key' or 'value' for example, instead of 'Line' - what would I put? https://i.imgur.com/0TQWTMl.png

Also, for when looking for a string within something like the URL - its not like we have 'lines' - would I provide the index at which they can find the substring within that string like I do there? Or no?

And then in the image below - see how its going through each section within the resource? Is that the approach we were looking for? Going through that list of items to iterate through per resource, adding what we find to a results binding and when we're done looking for those items in that resource, providing them as an array of objects? https://i.imgur.com/18gaZ43.png

I guess the above question stems from this image below as it doesn't really apply to all situations right? https://i.imgur.com/I0K14Es.png

Flags: needinfo?(odvarko)
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6ba635f14f1
Implement generic search across all resources. r=Honza
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: