1572144 - Support search result navigation

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

When the user clicks on a search results, the following should happen:

• Related resource (the search result comes from) should be selected in the request list
• The side bar should open
• The right side panel should be selected

Depending on the search result type, further navigation should be done

• Header - The Headers panel should be selected and related header highlighted. The panel content should auto scroll if needed to ensure that the header is visible.
• Cookie - The Cookies panel should be selected and related cookie highlighted. The panel content should auto scroll if needed to ensure that the cookie is visible.
• Response content - The Response panel should be selected and related line highlighted. The content (Code Mirror) should scroll if needed to make the line visible.
• Post data content - The Params panel should be selected and related line highlighted. The content (Code Mirror) should scroll if needed to make the line visible.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: search-navigation.patch

Prototype

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Search Navigation Prototype

Updating the prototype

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Search Navigation Prototype

Update prototype

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Search Navigation Prototype

Update

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4133af8f09accd274485a89a3bfb7d34195a2e29

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eeb78041695a458fd066d5a4721d869d6a13fc15

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=517a35cddc6d056d31400c0c5d022b62542ef7a5

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Search Navigation Prototype

Rebase + update

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06bbf9ce1e3b1e51147bfa0928fa827977795247

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: search-navigation.patch

Update

Comment 11

[lloan alas:[lloanalas]]

Attachment: Bug 1572144 - Support search result navigation. r=honza

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e344973418a
Support search result navigation. r=Honza

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out changeset 4e344973418a (Bug 1572144) for failing in browser_accessibility_mutations.js CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=264773118&resultStatus=testfailed%2Cbusted%2Cexception&revision=4e344973418a0ed6880b6ecf178cdc65751f45c6&searchStr=devtools

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264773118&repo=autoland&lineNumber=1599

BAckout: https://hg.mozilla.org/integration/autoland/rev/e81075cfc4299b99cefa5a7cd53caef86ae7f5e1

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98e552558193
Support search result navigation. r=Honza

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/98e552558193