Closed Bug 1573201 Opened 4 months ago Closed 21 days ago

Support some write access of WebExtension storage.local API data from the Storage panel of the WebExtension Addon Debugger toolbox

Categories

(WebExtensions :: Storage, enhancement, P1)

enhancement

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: bdanforth, Assigned: bdanforth)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

Breaking up Bug 1542035, so that it handles read-only access and this bug handles (some) write access.

Depends on: 1542035
  • Update the extensionStorage actor to enable some writing to extension storage.local through the Storage panel client.
  • All values in the client are displayed as strings, so the actor must stringify them before sending them to the client and parse them when receiving changes from the client. For this reason, there is currently limited write support.
    • Storage item values that are JSONifiable (numbers, strings, booleans, object literals, arrays and null) can be modified in the Storage panel.
    • Non-JSONifiable values cannot be modified, and will be represented by "[value *]" or "[object *]" in the panel, where * depends on the value type.
    • Storage item names can be modified in the storage panel.
  • In-line comments referencing Bugs 1542038 and 1542039 indicate places where the implementation may differ for local storage versus the other storage areas in the actor.
  • The parseItemValue method used in the client was moved to a shared directory, so that the actor could parse string values from the client in its editItem method.
Assignee: nobody → bdanforth
Priority: -- → P1

Here is the Bug 1573201 - Feature Technical Documentation as requested by QA.

Attachment #9084752 - Attachment description: Bug 1573201 - Add limited write support for extension storage.local in addon debugger → Bug 1573201 - Add limited write support for extension storage.local data in addon debugger
Attachment #9084752 - Attachment description: Bug 1573201 - Add limited write support for extension storage.local data in addon debugger → Bug 1573201 - Enable adding items and editing item names for extension storage.local data in addon debugger
Attachment #9084752 - Attachment description: Bug 1573201 - Enable adding items and editing item names for extension storage.local data in addon debugger → Bug 1573201 - Add limited write support for extension storage.local data in addon debugger

Item names must be strings to be editable.

Depends on D34416

Blocks: 1598224

Comment on attachment 9107718 [details]
Bug 1573201 - Enable adding items and editing item names for extension storage.local data in addon debugger

Revision D52483 was moved to bug 1598224. Setting attachment 9107718 [details] to obsolete.

Attachment #9107718 - Attachment is obsolete: true

Moved the work to add items and edit name fields in the Storage panel to a follow-up bug, Bug 1598224.

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dedca1647cfe
Add limited write support for extension storage.local data in addon debugger r=miker,rpl
Status: NEW → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Regressions: 1598960

Test Extension 3 for the QA Test Plan

(Test Extensions 1 and 2 are for regression testing of Bug 1542035 which is part of this bug's test plan; they can be found in that bug.)

Here is the QA Test Plan for this bug.

You need to log in before you can comment on or make changes to this bug.