1573201 - Support some write access of WebExtension storage.local API data from the Storage panel of the WebExtension Addon Debugger toolbox

Status: VERIFIED FIXED

(WebExtensions :: Storage, enhancement, P1)

Description

[Bianca Danforth [:bdanforth]]

Breaking up Bug 1542035, so that it handles read-only access and this bug handles (some) write access.

Comment 1

[Bianca Danforth [:bdanforth]]

Attachment: Bug 1573201 - Add limited write support for extension storage.local data in addon debugger

• Update the extensionStorage actor to enable some writing to extension storage.local through the Storage panel client.
• All values in the client are displayed as strings, so the actor must stringify them before sending them to the client and parse them when receiving changes from the client. For this reason, there is currently limited write support.
  • Storage item values that are JSONifiable (numbers, strings, booleans, object literals, arrays and null) can be modified in the Storage panel.
  • Non-JSONifiable values cannot be modified, and will be represented by "[value *]" or "[object *]" in the panel, where * depends on the value type.
  • Storage item names can be modified in the storage panel.
• In-line comments referencing Bugs 1542038 and 1542039 indicate places where the implementation may differ for local storage versus the other storage areas in the actor.
• The parseItemValue method used in the client was moved to a shared directory, so that the actor could parse string values from the client in its editItem method.

Comment 2

[Bianca Danforth [:bdanforth]]

Here is the Bug 1573201 - Feature Technical Documentation as requested by QA.

Comment 3

[Bianca Danforth [:bdanforth]]

Attachment: Bug 1573201 - Enable adding items and editing item names for extension storage.local data in addon debugger

Item names must be strings to be editable.

Depends on D34416

Comment 4

[Phabricator Automation]

Comment on attachment 9107718 [details]
Bug 1573201 - Enable adding items and editing item names for extension storage.local data in addon debugger

Revision D52483 was moved to bug 1598224. Setting attachment 9107718 [details] to obsolete.

Comment 5

[Bianca Danforth [:bdanforth]]

Moved the work to add items and edit name fields in the Storage panel to a follow-up bug, Bug 1598224.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dedca1647cfe
Add limited write support for extension storage.local data in addon debugger r=miker,rpl

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/dedca1647cfe

Comment 8

[Bianca Danforth [:bdanforth]]

Attachment: 1573201-test-extension-3-1.0.zip

Test Extension 3 for the QA Test Plan

(Test Extensions 1 and 2 are for regression testing of Bug 1542035 which is part of this bug's test plan; they can be found in that bug.)

Comment 9

[Bianca Danforth [:bdanforth]]

Here is the QA Test Plan for this bug.

Comment 10

[Miruna Curtean]

Verified that editing certain local storage items (string, number, boolean, null, Array and Object literal values are editable) and Deleting a single item or all items from the Extension local storage is possible. Tested on Windows pro 10, Ubuntu 18.04.3 LTS and macOS Catalina 10.15 on the latest Beta FF 72.0b9 (20191219234059).
Changes implemented through 1542035 have not regressed.
Marking this ticket as Verified fixed.