1573267 - Handlers for non-HTML file types only registered when setting default browser

Status: RESOLVED INVALID

(Firefox :: Installer, defect, P3)

Description

[Molly Howell (she/her) (mostly inactive)]

Firefox can open a number of file types that are not some permutation of HTML, and we have code that attempts to register as a valid handler for some of those (currently this list includes .pdf, .ogg, .oga, .ogv, and .webm). But we only attempt to create registrations for these file types when making ourselves the default browser, and we also try to make ourselves the default handler for them at the same time. We should separate those two actions and always register as a handler choice during install and PostUpdate.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

This isn't really that high a priority, but I thought I should fix it before the problem got paged out of my brain.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1573267 - Always create file type registry keys for all the types we support. r=agashlin

Comment 3

[Robert Strong (they/them - no direct email)]

Awhile back it was decided (I remember that UX and others were involved) that we should be the handler for PDF only if there wasn't already a handler and that other similar handlers should be treated the same way. Otherwise someone that had a local audio or movie player would end up launching Firefox for local audio or movie files of these types.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Yeah, I understand that and I don't propose changing it. The bug is that we're not registering ourselves as a possible handler for those types, except for when the user tells us to be the default browser, which I think is clearly wrong.

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Putting this on hold a bit because it needs UX/product input.

Comment 7

[Romain Testard [:RT]]

Matt, could this also potentially include protocol handlers like mailto or are file handlers and protocol handlers managed too differently?

Comment 8

[Molly Howell (she/her) (mostly inactive)]

The protocol handlers are not affected by this bug. Specifically for mailto though, we don't register Firefox for it because of bug 1496380.

Comment 9

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

This may be obsolete, see bug 1619122.

Comment 10

[Molly Howell (she/her) (mostly inactive)]

I think bug 1619122 did indeed obsolete this one, we should be shown as an option for all of these types (and quite a few more) now.